core&ui: contest can limit submission language #1007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import React from 'react'; | ||
| import AutoComplete from '.'; | ||
| import LanguageSelectAutoCompleteFC from './components/LanguageSelectAutoComplete'; | ||
|
|
||
| const Component = React.forwardRef<any, any>((props, ref) => { | ||
| const [value, setValue] = React.useState(props.value ?? ''); | ||
| return ( | ||
| <LanguageSelectAutoCompleteFC | ||
| ref={ref as any} | ||
| height="auto" | ||
| selectedKeys={value.split(',').map((i) => i.trim()).filter((i) => i)} | ||
| onChange={(v) => { | ||
| setValue(v); | ||
| props.onChange(v); | ||
| }} | ||
| multi={props.multi} | ||
| allowEmptyQuery={true} | ||
| /> | ||
| ); | ||
| }); | ||
|
|
||
| export default class LanguageSelectAutoComplete extends AutoComplete { | ||
| static DOMAttachKey = 'ucwLanguageSelectAutoCompleteInstance'; | ||
|
|
||
| constructor($dom, options) { | ||
| super($dom, { | ||
| classes: 'language-select', | ||
| ...options, | ||
| }); | ||
| } | ||
|
|
||
| attach() { | ||
| const value = this.$dom.val(); | ||
| this.component.render( | ||
| <Component | ||
| ref={(ref) => { this.ref = ref; }} | ||
| value={value} | ||
| multi={this.options.multi} | ||
| onChange={this.onChange} | ||
| />, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| window.Hydro.components.LanguageSelectAutoComplete = LanguageSelectAutoComplete; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { AutoComplete, AutoCompleteHandle, AutoCompleteProps } from '@hydrooj/components'; | ||
| import PropTypes from 'prop-types'; | ||
| import React, { forwardRef } from 'react'; | ||
|
|
||
| interface LanguageFakeDoc { | ||
| _id: string | ||
| name: string | ||
| } | ||
| const LanguageSelectAutoComplete = forwardRef<AutoCompleteHandle<LanguageFakeDoc>, AutoCompleteProps<LanguageFakeDoc>>((props, ref) => ( | ||
| <AutoComplete<LanguageFakeDoc> | ||
| ref={ref as any} | ||
| cacheKey={`language-${UiContext.domainId}`} | ||
| queryItems={async (query) => { | ||
| console.log('query', query); | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| const prefixes = new Set(Object.keys(window.LANGS).filter((i) => i.includes('.')).map((i) => i.split('.')[0])); | ||
| const listAll = Object.keys(window.LANGS) | ||
| .filter((i) => !prefixes.has(i)) | ||
| .map((i) => ({ | ||
| name: `${i.includes('.') ? `${window.LANGS[i.split('.')[0]].display || ''}/` : ''}${window.LANGS[i].display}`, | ||
| _id: i, | ||
| })); | ||
| const q = query.toLocaleLowerCase(); | ||
| return listAll.filter((el) => | ||
| el._id.toLocaleLowerCase().includes(q) || el.name.toLocaleLowerCase().includes(q), | ||
| ); | ||
| }} | ||
| fetchItems={async (ids) => { | ||
| // api('problems', { ids: ids.map((i) => +i) }, ['docId', 'pid', 'title']) | ||
| console.log('ids', ids); | ||
| const prefixes = new Set(Object.keys(window.LANGS).filter((i) => i.includes('.')).map((i) => i.split('.')[0])); | ||
| const listAll = Object.keys(window.LANGS) | ||
| .filter((i) => !prefixes.has(i)) | ||
| .map((i) => ({ | ||
| name: `${i.includes('.') ? `${window.LANGS[i.split('.')[0]].display || ''}/` : ''}${window.LANGS[i].display}`, | ||
| _id: i, | ||
| })); | ||
| return listAll; | ||
| }} | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| itemText={(pdoc) => pdoc.name} | ||
| itemKey={(pdoc) => pdoc._id} | ||
| renderItem={(pdoc) => ( | ||
| <div className="media"> | ||
| <div className="media__body medium"> | ||
| <div className="language-select__name">{pdoc.name}</div> | ||
| <div className="language-select__id">{pdoc._id}</div> | ||
| </div> | ||
| </div> | ||
| )} | ||
| {...{ | ||
| width: '100%', | ||
| height: 'auto', | ||
| listStyle: {}, | ||
| multi: false, | ||
| selectedKeys: [], | ||
| allowEmptyQuery: false, | ||
| freeSolo: false, | ||
| freeSoloConverter: (input) => input, | ||
| ...props, | ||
| }} | ||
| /> | ||
| )); | ||
|
|
||
| LanguageSelectAutoComplete.propTypes = { | ||
| width: PropTypes.string, | ||
| height: PropTypes.string, | ||
| listStyle: PropTypes.object, | ||
| onChange: PropTypes.func.isRequired, | ||
| multi: PropTypes.bool, | ||
| selectedKeys: PropTypes.arrayOf(PropTypes.string), | ||
| allowEmptyQuery: PropTypes.bool, | ||
| freeSolo: PropTypes.bool, | ||
| freeSoloConverter: PropTypes.func, | ||
| }; | ||
|
|
||
| LanguageSelectAutoComplete.displayName = 'LanguageSelectAutoComplete'; | ||
|
|
||
| export default LanguageSelectAutoComplete; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve value parsing robustness and error handling.
The current value splitting logic may fail with malformed input and lacks error handling for the onChange callback.
const Component = React.forwardRef<any, any>((props, ref) => { - const [value, setValue] = React.useState(props.value ?? ''); + const [value, setValue] = React.useState(() => { + const initialValue = props.value ?? ''; + return typeof initialValue === 'string' ? initialValue : String(initialValue); + }); + + const parseValue = (val: string) => { + if (!val || typeof val !== 'string') return []; + return val.split(',').map((i) => i.trim()).filter((i) => i); + }; + return ( <LanguageSelectAutoCompleteFC ref={ref as any} height="auto" - selectedKeys={value.split(',').map((i) => i.trim()).filter((i) => i)} + selectedKeys={parseValue(value)} onChange={(v) => { - setValue(v); - props.onChange(v); + try { + setValue(v); + props.onChange?.(v); + } catch (error) { + console.error('Error in LanguageSelectAutoComplete onChange:', error); + } }} multi={props.multi} allowEmptyQuery={true} /> ); });📝 Committable suggestion
🤖 Prompt for AI Agents