Skip to content

chore(dfir_datalog)!: move datalog from repo, remove datalog playground from web, #1809 #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Apr 11, 2025

#1809

moved to https://github.com/hydro-project/dfir-datalog

tests moved in hydro-project/dfir-datalog#1

Removes dedalus examples in hydro_cli_examples

Changes pinned nightly rust version from 2024-04-05 to 2024-04-04 as the former did not have intel mac support.

BREAKING CHANGE: dfir_datalog items are no longer included/re-exported by dfir_rs

@MingweiSamuel MingweiSamuel changed the title chore(dfir_datalog): remove from repo, moved to https://github.com/hydro-project/dfir-datalog chore(dfir_datalog): remove from repo, moved to https://github.com/hydro-project/dfir-datalog, #1809 Apr 11, 2025
@MingweiSamuel MingweiSamuel changed the title chore(dfir_datalog): remove from repo, moved to https://github.com/hydro-project/dfir-datalog, #1809 chore(dfir_datalog): move datalog from repo, remove datalog playground from web, #1809 Apr 11, 2025
@MingweiSamuel MingweiSamuel marked this pull request as ready for review April 14, 2025 20:54
@MingweiSamuel MingweiSamuel changed the title chore(dfir_datalog): move datalog from repo, remove datalog playground from web, #1809 chore(dfir_datalog)!: move datalog from repo, remove datalog playground from web, #1809 Apr 17, 2025
Copy link
Collaborator

@jhellerstein jhellerstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check nits but otherwise LGTM

@@ -16,7 +16,7 @@ TEST_HYDRO=false
TEST_HYDRO_CLI=false
TEST_ALL=false

while (( $# )) do
while (( $# )); do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug before or after??

@@ -1,5 +1,5 @@
[toolchain]
channel = "nightly-2025-04-05" # Make sure to update `template/*/rust-toolchain.toml` as well.
channel = "nightly-2025-04-04" # Make sure to update `template/*/rust-toolchain.toml` as well.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@@ -1,2 +1,2 @@
[toolchain]
channel = "nightly-2025-04-05"
channel = "nightly-2025-04-04"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@@ -1,4 +1,4 @@
[toolchain]
channel = "nightly-2025-04-05"
channel = "nightly-2025-04-04"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants