feat(hydro_cli): added basic wrapper for hydro deploy Maelstrom integration #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p` to `hydroflow::util` instead (hydro-project#677) Refs: hydro-project#675
For release on crates.io for v0.1
…1.0, hydroflow_lang v0.1.0, hydroflow_datalog_core v0.1.0, hydroflow_datalog v0.1.0, hydroflow_macro v0.1.0, lattices v0.1.1, hydroflow v0.1.0
We had a crash in a recent build, but no core dump was uploaded. This will hopefully help.
Renamed from Hydro CLI because the CLI isn't really the main thing. Also moves the Hydroflow docs to a subdirectory and sets up a dropdown for multiple docs.
…quires (hydro-project#694) Hopefully this will work on the first try? Not really a good way to test it. It seems that acquiring the GIL in async/await code is asking for trouble, so this also eliminates those.
…ct#702) * rename: keyed_fold/keyed_reduce -> fold_keyed/reduce_keyed * remove group_by
|
See https://www.conventionalcommits.org/en/v1.0.0/ for the commit format and run |
|
also recommend rebasing on the latest main |
…ouble-labelled edges (hydro-project#949) Fix: hydro-project#934
…-project#948) BREAKING CHANGE: first argument of fold() is now a closure instead of a value
RyanAlameddine
force-pushed
the
maelstrom
branch
3 times, most recently
from
75c3102 to
43c5713
Compare
shadaj
requested changes
Nov 5, 2023
hydro_cli_maelstrom/src/main.rs
Outdated
| source_port_names: &[String], | ||
| child_stdin: &mut ChildStdin, | ||
| ) -> Result<()> { | ||
| let localhost = HashMap::from([("TcpPort", "127.0.0.1")]); |
There was a problem hiding this comment.
To improve the type safety here, we should use the original enum and serialize it with serde.
There was a problem hiding this comment.
Also, would be great to use Unix sockets when available.
hydro_cli_maelstrom/src/main.rs
Outdated
| let connection_defs_str = serde_json::to_string(&connection_defs)?; | ||
| let formatted_defns = format!("start: {connection_defs_str}\n"); | ||
| child_stdin.write_all(formatted_defns.as_bytes()).await?; | ||
| #[cfg(debug_assertions)] |
There was a problem hiding this comment.
eventually, we'll want to drop this altogether
hydro_cli_maelstrom/src/main.rs
Outdated
| // Send the body string to the target port | ||
| let body_string = serde_json::to_string(body)?; | ||
| #[cfg(debug_assertions)] | ||
| println!("Sending line {}", body_string); |
There was a problem hiding this comment.
same as above wrt removing eventually
hydro_cli_maelstrom/src/main.rs
Outdated
| // {"src":"n1","dest":"c1","body":{"echo":"hello world!","msg_id":0,"in_reply_to":1,"type":"echo_ok"}} | ||
|
|
||
| // parse line to string | ||
| let raw_line: String = bincode::deserialize(&line).unwrap(); |
There was a problem hiding this comment.
This is a bit funky; we should probably have a special MaelstromResponse type that's available to both this helper and the actual Hydroflow program. That way instead of using stringly-typed data we can have proper data types.
hydro_cli_maelstrom/src/main.rs
Outdated
| #[tokio::main] | ||
| async fn main() -> Result<()> { | ||
| // let path = r"C:\Users\rhala\Code\hydroflow\target\debug\examples\echo"; | ||
| let path = r"/mnt/c/Users/rhala/Code/hydroflow/target/debug/examples/maelstrom_unique_id"; |
There was a problem hiding this comment.
Should be read from command line args or an environment variable.
hydro_cli_maelstrom/src/main.rs
Outdated
| // let port_input_str = r#"[{"maelstrom_type":"echo","port_name":"echo_in","direction":"Source"},{"maelstrom_type":"echo_ok","port_name":"echo_out","direction":"Sink"}]"#; | ||
|
|
||
| // unique id gen setup | ||
| let port_input_str = r#"[{"maelstrom_type":"generate","port_name":"gen_in","direction":"Source"},{"maelstrom_type":"generate_ok","port_name":"ok_out","direction":"Sink"}]"#; |
There was a problem hiding this comment.
We should declare Rust datatypes for each of these messages and use serde_json to serialize them.
RyanAlameddine
force-pushed
the
maelstrom
branch
3 times, most recently
from
f84c542 to
9f9f757
Compare
RyanAlameddine
force-pushed
the
maelstrom
branch
from
9f9f757 to
3451d6b
Compare
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
e9a87eb to
6039078
Compare
MingweiSamuel
force-pushed
the
main
branch
4 times, most recently
from
4f84634 to
0e64791
Compare
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
fb8b3b3 to
a2ec110
Compare
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
b569212 to
fb8393a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.