Fix: font lock updates #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be a free merge. How about |
fosskers
reviewed
Mar 12, 2025
Comment on lines
+290
to
+291
| "case" "branch" | ||
| "ecase" "ebranch" |
There was a problem hiding this comment.
These may have been since replaced by match.
pkulev
reviewed
Apr 21, 2025
| @@ -176,6 +176,7 @@ | |||
| "max" | |||
| "memoryview" | |||
| "min" | |||
| "match" | |||
There was a problem hiding this comment.
It seems that the whole list can be replaced by reusing python mode:
(defconst hy-font-lock--python-builtins
(seq-concatenate 'list
(seq-copy python--treesit-builtins)
'("--package--"
"--import--"
"--all--"
"--doc--"
"--name--"))
"Builtin names available in Python normally.")
| @@ -219,17 +220,25 @@ | |||
|
|
|||
| (defconst hy-font-lock--exceptions | |||
| '("ArithmeticError" "AssertionError" "AttributeError" "BaseException" | |||
| "DeprecationWarning" "EOFError" "EnvironmentError" "Exception" | |||
There was a problem hiding this comment.
Constants and exceptions as well can be reused.
;;;; Constants
(defconst hy-font-lock--constants (seq-copy python--treesit-constants)
"Constant names in Hy.")
;;;; Exceptions
(defconst hy-font-lock--exceptions (seq-copy python--treesit-exceptions)
"Exception and error names.")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.