Moving build requirements to pyproject.toml#123
Merged
Kodiologist merged 2 commits intohylang:masterfrom Oct 28, 2025
Merged
Conversation
Member
Member
|
Yup I can take a look! |
Member
|
Works based on my own local testing; the main thing I wanted to confirm is that we wouldn't get a regression of #42. I'll formally approve once the AUTHORS (and NEWS?) commits are added! |
Member
|
Yep, don't forget AUTHORS and NEWS. I would also suggest some whitespace for readability: requires = ["setuptools >= 42", "wheel", "hy >= 1"] |
Contributor
Author
|
Added the updates to AUTHORS and NEWS and some spaces. Does everything look good to you? |
Contributor
Author
|
Misclicked on close, sorry about that |
Contributor
Author
|
Hi @Kodiologist would it be possible to create a patch version release from this change? |
Member
|
Yes, it's been a while since the last release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122.
According to https://setuptools.pypa.io/en/latest/build_meta.html the
setup_requiresparameter insetup.pyis deprecated. From the linked documentation:This PR moves the dependencies specified in
setup_requiresto a dedicatedpyproject.toml.Adding a
pyproject.tomlalso helps not relying on fallback behavior from pip for legacy projects: https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour .It would be great if this could be turned into a release to PyPi