Skip to content

Comments

Moving build requirements to pyproject.toml#123

Merged
Kodiologist merged 2 commits intohylang:masterfrom
SoulofAkuma:master
Oct 28, 2025
Merged

Moving build requirements to pyproject.toml#123
Kodiologist merged 2 commits intohylang:masterfrom
SoulofAkuma:master

Conversation

@SoulofAkuma
Copy link
Contributor

@SoulofAkuma SoulofAkuma commented Oct 21, 2025

Closes #122.

According to https://setuptools.pypa.io/en/latest/build_meta.html the setup_requires parameter in setup.py is deprecated. From the linked documentation:

With the changes introduced by PEP 517 and PEP 518, the setup_requires configuration field was deprecated in setup.cfg and setup.py, in favour of directly listing build dependencies in the requires field of the build-system table of pyproject.toml.

This PR moves the dependencies specified in setup_requires to a dedicated pyproject.toml.
Adding a pyproject.toml also helps not relying on fallback behavior from pip for legacy projects: https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour .

It would be great if this could be turned into a release to PyPi

@Kodiologist
Copy link
Member

@scauligi Can you review this, since you wrote #46?

@scauligi
Copy link
Member

Yup I can take a look!

@scauligi
Copy link
Member

Works based on my own local testing; the main thing I wanted to confirm is that we wouldn't get a regression of #42.
We'll likely want a similar change for hy itself as well.

I'll formally approve once the AUTHORS (and NEWS?) commits are added!

@Kodiologist
Copy link
Member

Yep, don't forget AUTHORS and NEWS.

I would also suggest some whitespace for readability:

requires = ["setuptools >= 42", "wheel", "hy >= 1"]

@SoulofAkuma
Copy link
Contributor Author

Added the updates to AUTHORS and NEWS and some spaces. Does everything look good to you?

@SoulofAkuma SoulofAkuma reopened this Oct 28, 2025
@SoulofAkuma
Copy link
Contributor Author

Misclicked on close, sorry about that

@Kodiologist Kodiologist merged commit 7e78788 into hylang:master Oct 28, 2025
6 checks passed
@SoulofAkuma
Copy link
Contributor Author

Hi @Kodiologist would it be possible to create a patch version release from this change?
The broken setuptools build is currently preventing us from building a project of ours that depends on hyrule

@Kodiologist
Copy link
Member

Yes, it's been a while since the last release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure with latest versions of pip/setuptools/wheel

3 participants