Skip to content

Fix inactive (disabled) days being clickable #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix inactive (disabled) days being clickable #389

merged 1 commit into from
Mar 19, 2025

Conversation

vanyasem
Copy link
Contributor

Inactive days were still clickable, despite being disabled. They had an InkWell (Material Ripple) animation as well
This PR fixes this

hyochan
hyochan approved these changes Mar 19, 2025
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also resolve #381?

@hyochan hyochan merged commit 89f2719 into hyochan:main Mar 19, 2025
@hyochan hyochan added bugfix Fixed bug enhancement New feature or request labels Mar 19, 2025
@vanyasem
Copy link
Contributor Author

@hyochan no, #381 is talking about adding an ability to specify a custom list of inactive (disabled) dates in calendar's constructor

@vanyasem vanyasem deleted the sem-fix-inactive-days-clickable branch March 19, 2025 17:02
@vanyasem
Copy link
Contributor Author

@hyochan I made a new PR that resolves #381: #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
bugfix Fixed bug enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanyasem @hyochan