fix(ios): serialize UInt64 transaction IDs as strings to prevent E_DEVELOPER_ERROR during finishTransaction #2931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a serialization issue affecting transaction identifiers (id and originalID) for iOS. We've observed transaction IDs—particularly from family-shared subscriptions—with UInt64 values exceeding JavaScript’s MAX_SAFE_INTEGER (2^53 - 1), such as 504319184420155588.
When these large integer IDs are transmitted from native Swift code to JavaScript via the React Native bridge, they lose numeric precision. This loss causes transaction IDs to become corrupted, resulting in errors like E_DEVELOPER_ERROR with the message Invalid transaction Id when calling finishTransaction with IDs obtained from the purchaseUpdatedListener. Consequently, transactions may fail to complete properly.
Proposed Changes