UI #4
Open
UI #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/hyper-ui/src/components/assets-explorer/index.vue # packages/hyper-ui/src/components/frequently-traded-assets/index.vue # packages/hyper-ui/src/components/join-community/index.vue # packages/hyper-ui/src/components/popups/add-collection.vue # packages/hyper-ui/src/index.js
highruned
commented
Oct 28, 2019
| @@ -16,7 +16,7 @@ | |||
| export default { | |||
| props: { | |||
| percent: { | |||
| type: Number, | |||
| type: [Number, String], | |||
There was a problem hiding this comment.
This is bad. It should only accept one or the other
highruned
commented
Oct 28, 2019
| @@ -146,8 +146,8 @@ export default { | |||
| default: 0 | |||
| }, | |||
| releaseDate: { | |||
| type: String, | |||
| default: new Date() | |||
| type: [String, Date], | |||
There was a problem hiding this comment.
This is bad. It should only accept one or the other. It should be the responsibility of the user to pass the correct type.
There was a problem hiding this comment.
Ok. So what we should use for Date field?
There was a problem hiding this comment.
String. UI components should be flexible, they shouldn't enforce the way a date is displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.