feat: reduce number of order database upserts in order validation cro… #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
Jipperism
force-pushed
the
fix/reduce-number-of-order-invalidations
branch
from
1f1187d to
48f13b8
Compare
bitbeckers
requested changes
Mar 17, 2025
Jipperism
force-pushed
the
fix/reduce-number-of-order-invalidations
branch
from
48f13b8 to
6c3c168
Compare
…njob, reduce rpc calls - lowers the amount of upserts done, by only updating orders that have their validity or error codes changed. Previously, it was updating all orders that we're checked, resulting in unnecessary cache invalidations - properly utilizes the checkMakerOrders method to prevent unnecessary calls to the RPC endpoint, which might have been related with our infura issues.
Jipperism
force-pushed
the
fix/reduce-number-of-order-invalidations
branch
from
6c3c168 to
3855f41
Compare
bitbeckers
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the order invalidation logic in
SupabaseDataServicein two ways:checkMakerOrdersmethod to prevent unnecessary calls to the RPC endpoint, which might have been related with our infura issues.