Safe integration marketplace listings #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the previous PRs introduced a health check endpoint which was missing the autogenerated code updates.
pheuberger
force-pushed
the
safe-integration-marketplace-listings
branch
from
55bec59 to
9f30345
Compare
pheuberger
requested review from
bitbeckers and
Jipperism
and removed request for
bitbeckers
Jipperism
reviewed
Apr 5, 2025
bitbeckers
reviewed
Apr 6, 2025
pheuberger
force-pushed
the
safe-integration-marketplace-listings
branch
from
9f30345 to
35e9425
Compare
pheuberger
force-pushed
the
safe-integration-marketplace-listings
branch
from
35e9425 to
e65fbb9
Compare
pheuberger
force-pushed
the
safe-integration-marketplace-listings
branch
from
e65fbb9 to
3c368fd
Compare
|
@Jipperism @bitbeckers I addressed your feedback. Please have another look and resolve everything you're satisfied with <3 |
Without this patch users cannot use their Safe to create marketplace listings. This extends the POST /marketplace/orders endpoint to accept a new multisig payload type. This payload type carries the Safe message hash and chain id only. Upon receiving this payload the API will get the data from the Safe message and put it into a signature request. This patch also adds a command that verifies pending create order signature requests. I'm really sorry I had to lower the coverage threshold, but since bitbeckers big refactor is incoming anyway, it would be best to improve coverage once the dust has settled.
We already have it, so why not use it?
Since we already have this base error we can keep it DRY.
pheuberger
force-pushed
the
safe-integration-marketplace-listings
branch
from
3c368fd to
d181899
Compare
bitbeckers
approved these changes
Apr 7, 2025
Jipperism
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating marketplace listings from your Safe.
It therefore changes the payload structure for the
POST /marketplace/ordersrequest to expect a discriminated union of either the EOA request or the multisig request. For backwards compatibility the previous request structure is also supported.My recommendation would be to ship this PR and the Hypercerts SDK PR first, update the app to point to the new SDK version and test the review build there.