Skip to content

Safe integration marketplace listings #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pheuberger
Copy link
Member

This PR adds support for creating marketplace listings from your Safe.

It therefore changes the payload structure for the POST /marketplace/orders request to expect a discriminated union of either the EOA request or the multisig request. For backwards compatibility the previous request structure is also supported.

My recommendation would be to ship this PR and the Hypercerts SDK PR first, update the app to point to the new SDK version and test the review build there.

One of the previous PRs introduced a health check endpoint which was
missing the autogenerated code updates.
@pheuberger pheuberger force-pushed the safe-integration-marketplace-listings branch from 9f30345 to 35e9425 Compare April 7, 2025 13:58
@pheuberger pheuberger force-pushed the safe-integration-marketplace-listings branch from 35e9425 to e65fbb9 Compare April 7, 2025 14:00
@pheuberger pheuberger force-pushed the safe-integration-marketplace-listings branch from e65fbb9 to 3c368fd Compare April 7, 2025 14:02
@pheuberger
Copy link
Member Author

@Jipperism @bitbeckers I addressed your feedback. Please have another look and resolve everything you're satisfied with <3

Without this patch users cannot use their Safe to create marketplace
listings.

This extends the POST /marketplace/orders endpoint to accept a new
multisig payload type. This payload type carries the Safe message hash
and chain id only. Upon receiving this payload the API will get the data
from the Safe message and put it into a signature request.

This patch also adds a command that verifies pending create order
signature requests.

I'm really sorry I had to lower the coverage threshold, but since
bitbeckers big refactor is incoming anyway, it would be best to improve
coverage once the dust has settled.
We already have it, so why not use it?
Since we already have this base error we can keep it DRY.
@pheuberger pheuberger force-pushed the safe-integration-marketplace-listings branch from 3c368fd to d181899 Compare April 7, 2025 16:02
@pheuberger pheuberger merged commit fcf1569 into hypercerts-org:develop Apr 8, 2025
1 check passed
@pheuberger pheuberger deleted the safe-integration-marketplace-listings branch April 8, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants