Deploy to PROD #283
Merged
Deploy to PROD #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the health check endpoint to be part of the TSOA routes. This enables users to validate the application health and adds the endpoint to the Swagger spec
- important note: subscribing to a table that doesn't have realtime publications enabled, disables subscriptions to all tables 🥴
Without this patch filtering doesn't work on collections. The following
query returns all collections instead of the one that's filtered for:
{
collections(where: { name: { eq: "test"}}) {
data {
name
id
hypercerts {
hypercert_id
}
}
}
}
The same holds true for ids.
Tests would complain when the Alchemy env var isn't found. The tests shouldn't even need it. This most likely came to be when the RPC URL building was changed and this test was missed. The new mocks catch that oversight.
Adding code inside of baseTypes.ts requires us to lower the coverage thresholds as it's notoriously difficult to test.
…ring fix(graphql): filter on collections not working
The Filecoin documentation doesn't exactly specifiy the full path to be used with the SafeAPIKit SDK. After some digging I found that the API isn't expected to be under /api by default. That means it needs to be specified explicitly. https://docs.safe.global/sdk/api-kit/guides/migrate-to-v2
Without this patch the Multisig upsert strategy is trying to construct the SafeAPIKit instance using the default constructor. The problem is that on Filecoin and Filecoin Calibration the transaction service is hosted by a third party and thus needs a custom txServiceUrl in the config.
Updates dependencies and generated content of API
Updates the cache invalidation method to invalidate based on changes to hypercert_allow_list_records instead of allow_lists. This enforces cache invalidation when a record is claimed
Refactors the SupabaseCachingService to get all hypercert columns except for the image. Renamed the getMetadata method to getMetadataWithoutImage to make this explicit. Introduces MetadataImageService for fetching the image when the field is selected in a metadata query.
…age_fetching Separate metadata image fetching from metadata query
Add health check to TSOA routes
Fix user controller to use custom Safe API Kit instance when interacting with Filecoin networks
This commit fixes the query by explicity calling for the metadata columns in the join query in SupabaseCachingService.ts
…_error Fix/ambiguous metadata id error
- removes unused payload line in supabase.ts - when invalidation allowlist record cache on update use record id - when invalidating allowlist record cache on insert invalidate all
…fresh Allowlist claim response cache refresh
Adds Ankr, ChainUp, and Lava RPC providers to the EvmClientFactory for improved Filecoin network connectivity
Without specifying that selectAll() should give preference to columns present in the claims table, it ends up selecting fractions.units when the join is applied.
this was previously hidden due to the ts-expect-error comment, used because of the type mismatch
Introduces a new cronjob to periodically validate and potentially invalidate marketplace orders. The cronjob checks all valid orders, and certain invalid orders with specific error codes.
it no longer makes sense to keep the error codes in the marketplace sdk as the only place they will be used is here.
As we're getting high loads on Sentry spans, we reduce the sampling rate from 1.0 to 0.1 for production and 1.0 on staging. The reason for this is to primarily lower the amount of traces sent. However, we keep it 100% on staging to detect bugs and as traffic is lower there
…_rates chore(sentry): lower polling rates
…njob, reduce rpc calls - lowers the amount of upserts done, by only updating orders that have their validity or error codes changed. Previously, it was updating all orders that we're checked, resulting in unnecessary cache invalidations - properly utilizes the checkMakerOrders method to prevent unnecessary calls to the RPC endpoint, which might have been related with our infura issues.
Fixes a bug where the schema_uid was not selected correctly, which resulted in errors when fetching eas_schema using graphql as it's non-nullable.
Jipperism
requested review from
bitbeckers and
pheuberger
and removed request for
bitbeckers
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
pheuberger
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.