Deploy to PROD #285
Merged
Deploy to PROD #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the previous PRs introduced a health check endpoint which was missing the autogenerated code updates.
Without this patch users cannot use their Safe to create marketplace listings. This extends the POST /marketplace/orders endpoint to accept a new multisig payload type. This payload type carries the Safe message hash and chain id only. Upon receiving this payload the API will get the data from the Safe message and put it into a signature request. This patch also adds a command that verifies pending create order signature requests. I'm really sorry I had to lower the coverage threshold, but since bitbeckers big refactor is incoming anyway, it would be best to improve coverage once the dust has settled.
We already have it, so why not use it?
Since we already have this base error we can keep it DRY.
…listings Safe integration marketplace listings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.