feat: batch claim fraction #378

tnkshuuhei · 2025-02-04T10:16:28Z

[FE] Reject or claim fractions from allowlist in UI #30
[FE] Add checkboxes for claimable fractions #83
[claim] can't click on hypercert to view #207
[UI] User should be asked to switch chains when trying to claim a fraction on the wrong chain #307
filter unclaimed fraction, and allow user to claim on only filtered chain

refactored unclaimed hypercerts list to use a table-based UI with: - new table components for unclaimed fractions validation - added row selection and pagination - implemented dropdown actions for each row - disabled to click "claim" button if the connected address !== user_address to prevent from unintended behavier

…onent Moved the `createExtraContent` function from the `useMintHypercert` hook to a new global component file, improving code organization and reusability.

…ep dialog

Implemented a new batch claim button that enables claiming multiple hypercert fractions in a single transaction

this component has replaced to table component

vercel · 2025-02-04T10:16:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hypercerts-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2025 2:12am

Implemented table filtering functionality for unclaimed hypercerts. This is necessary to batch claim function because user cannot claim on multiple chain in a single transaction

This improves UX when user try to claim hypercert on specific chain which is not connected chain.

This change is intended to show unclaimed hypercert on connected chainId so that user can easily claim them. If user wallet is not connected, then show all unclaimed hypercerts

This change is intended to prevent selecting rows from different chains. And pass selected chain ID to batch claim button.

set default pageSize to 25 from 10 for better UX

This change is intended to avoid confusion

…units columns merged chain and time_frame column into title column because setting multiple hypercert_id accessor breaks filter. Title and time frame should be queried from metadata field.

…units columns

changes: - refactor handleRowSelectionChange function and made it more simple logic - add description for functions inside the unclaimed-fraction-table component - harmonize button styling

holkexyz · 2025-02-05T16:49:59Z

Some suggested changes

Change text from "0 of 2 row(s) selected" to "0 of 2 hypercert(s) selected"
The hypercert can be opened by clicking on the title, then I don't think we need the additional menu at the end of the row (even though it is nice, if we want to add other functions)
Instead of the ID, display the actual title
Switch the "claim" button at the end of the row to the default black button
Call the "Title" column "Hypercert" as it includes multiple parts
For mobile: Maybe we drop all columns except the first that is now called "Hypercert" and only add the "Claim" button (not sure if this is the best way of improving the mobile version

Only if it is simple

Combine the columns "Claimable Units" and "Total Units" to a column "Claimable fraction", which then displays 20% or 63% (rounding to 2 digits behind the comma)

- apply responsive design for mobile friendly - change columns display to proper column title - change claimable units row to show portion of fraction user can claim

tnkshuuhei · 2025-02-06T01:48:55Z

@holkexyz thank you for review. working on it

Some suggested changes

Change text from "0 of 2 row(s) selected" to "0 of 2 hypercert(s) selected"
The hypercert can be opened by clicking on the title, then I don't think we need the additional menu at the end of the row (even though it is nice, if we want to add other functions)
Instead of the ID, display the actual title
Switch the "claim" button at the end of the row to the default black button
Call the "Title" column "Hypercert" as it includes multiple parts
For mobile: Maybe we drop all columns except the first that is now called "Hypercert" and only add the "Claim" button (not sure if this is the best way of improving the mobile version
Combine the columns "Claimable Units" and "Total Units" to a column "Claimable fraction", which then displays 20% or 63% (rounding to 2 digits behind the comma)

fetched hypercert metadata inside the hypercerts tab content component because this should be done before rendering client component. ideally image url should be fetched at the same time.

bitbeckers

The UI/UX is a huge improvement, thank you!

Two points outside of the comments:

The refresh of the Claimable and Owner tabs tooks longer than expected, is the cache invalidation triggered?
Actionable buttons have a black fill with white text

app/profile/[address]/hypercerts-tab-content.tsx

components/global/extra-content.tsx

components/profile/unclaimed-hypercert-butchClaim-button.tsx

components/profile/unclaimed-hypercert-claim-button.tsx

components/profile/unclaimed-table/unclaimed-fraction-columns.tsx

components/profile/unclaimed-table/unclaimed-fraction-table.tsx

… fetch hypercert metadata This change is intended to improve efficiency by focusing data on metadata rather than executing unnecessary queries.

Changes include: - Replaced "hypercert" with "fraction" in UI text and error messages - Updated claim button styling and disabled state logic - Modified revalidation paths after claiming - Added getAddress utility to ensure consistent address comparison

Simplified button rendering.

because it takes time to be revalidated

components/global/extra-content.tsx

components/profile/unclaimed-hypercert-butchClaim-button.tsx

components/profile/unclaimed-hypercert-claim-button.tsx

hypercerts/hooks/useMintHypercert.ts

tnkshuuhei · 2025-02-06T12:48:24Z

@bitbeckers

The refresh of the Claimable and Owner tabs tooks longer than expected, is the cache invalidation triggered?

I thought this is because block confirmation was set to 3, so removed it here: 0b5088f

I'm not sure whether this is enough or not...

hypercerts-app/components/profile/unclaimed-hypercert-claim-button.tsx

Lines 98 to 100 in 0b5088f

    
           `/hypercerts/${selectedHypercert?.hypercert_id}`, 
        
           `/profile/${account.address}?tab=hypercerts-claimable`, 
        
           `/profile/${account.address}?tab=hypercerts-owned`,

Changes include: - Modify createExtraContent to use object parameter - Remove unnecessary console.log

Jipperism

Let's continue the revalidation stuff in #420 , lgtm now

github-actions · 2025-02-25T19:33:51Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tnkshuuhei added 5 commits February 4, 2025 16:41

refactor(hypercerts): extract extra content creation to separate comp…

cae4a5a

…onent Moved the `createExtraContent` function from the `useMintHypercert` hook to a new global component file, improving code organization and reusability.

feat(profile): enhance unclaimed hypercert claim flow with step-by-st…

0518237

…ep dialog

feat(profile): add batch claim functionality for unclaimed hypercerts

dd15830

Implemented a new batch claim button that enables claiming multiple hypercert fractions in a single transaction

refactor(profile): remove unclaimed hypercert list item component

e59ff97

this component has replaced to table component

tnkshuuhei self-assigned this Feb 4, 2025

tnkshuuhei added 9 commits February 5, 2025 11:11

feat(profile): add chain filtering to unclaimed hypercerts table

f5ad0ea

Implemented table filtering functionality for unclaimed hypercerts. This is necessary to batch claim function because user cannot claim on multiple chain in a single transaction

feat(profile): add chain switching for claiming unclaimed hypercert

64bfe4d

This improves UX when user try to claim hypercert on specific chain which is not connected chain.

feat(profile): automatically set chainId filter to connected chainId

9f97c56

This change is intended to show unclaimed hypercert on connected chainId so that user can easily claim them. If user wallet is not connected, then show all unclaimed hypercerts

feat(profile): disable to choose multiple chain ATST

5c064bb

This change is intended to prevent selecting rows from different chains. And pass selected chain ID to batch claim button.

chore: increased default pagesize

1226659

set default pageSize to 25 from 10 for better UX

fix(profile): correct dropdownItem for viewing hypercert

533a6ee

chore: disabled batch claim button when user is not selected

4032a18

This change is intended to avoid confusion

refactor(profile): improve unclaimed hypercerts table design and add …

33e901b

…units columns merged chain and time_frame column into title column because setting multiple hypercert_id accessor breaks filter. Title and time frame should be queried from metadata field.

feat(profile): add sorting to unclaimed hypercerts table units/total_…

207c95a

…units columns

vercel bot deployed to Preview February 5, 2025 12:26 View deployment

refactor(profile): improve table toolbar and row selection logic

8246187

changes: - refactor handleRowSelectionChange function and made it more simple logic - add description for functions inside the unclaimed-fraction-table component - harmonize button styling

vercel bot deployed to Preview February 5, 2025 12:42 View deployment

This was referenced Feb 5, 2025

[bug] user should not be able to click on "buy" if on wrong chain #401

Closed

[UI] User should be asked to switch chains when trying to claim a fraction on the wrong chain #307

Closed

style(profile): responsive table view and some UX improvement

d1bddb8

- apply responsive design for mobile friendly - change columns display to proper column title - change claimable units row to show portion of fraction user can claim

vercel bot deployed to Preview February 6, 2025 01:48 View deployment

feat(profile): unclaimed hypercerts with metadata

debdc00

fetched hypercert metadata inside the hypercerts tab content component because this should be done before rendering client component. ideally image url should be fetched at the same time.

vercel bot deployed to Preview February 6, 2025 02:42 View deployment

tnkshuuhei changed the title ~~[WIP] feat: batch claim fraction~~ feat: batch claim fraction Feb 6, 2025

tnkshuuhei marked this pull request as ready for review February 6, 2025 03:05

tnkshuuhei requested a review from bitbeckers February 6, 2025 03:05

tnkshuuhei requested review from Jipperism and pheuberger February 6, 2025 03:05

bitbeckers requested changes Feb 6, 2025

View reviewed changes

bitbeckers added the enhancement New feature or request label Feb 6, 2025

This was linked to issues Feb 6, 2025

[FE] Reject or claim fractions from allowlist in UI #30

Closed

[FE] Add checkboxes for claimable fractions #83

Closed

feat(hypercerts): introduced a new getHypercertMetadata function to…

3ae229b

… fetch hypercert metadata This change is intended to improve efficiency by focusing data on metadata rather than executing unnecessary queries.

bitbeckers linked an issue Feb 6, 2025 that may be closed by this pull request

[UI] add modal for successfully claiming a fraction #287

Closed

bitbeckers approved these changes Feb 6, 2025

View reviewed changes

vercel bot deployed to Preview February 6, 2025 12:22 View deployment

tnkshuuhei added 2 commits February 6, 2025 21:36

refactor(components): migrate extra-content to React JSX syntax

aabe2a1

Simplified button rendering.

refactor(profile): remove tx confirmations

0b5088f

because it takes time to be revalidated

vercel bot deployed to Preview February 6, 2025 12:41 View deployment

Jipperism requested changes Feb 6, 2025

View reviewed changes

refactor(components): update createExtraContent and claim buttons

5478440

Changes include: - Modify createExtraContent to use object parameter - Remove unnecessary console.log

vercel bot deployed to Preview February 7, 2025 02:12 View deployment

Jipperism approved these changes Feb 7, 2025

View reviewed changes

bitbeckers merged commit 9e52170 into dev Feb 7, 2025
2 checks passed

bitbeckers deleted the feat/batch-claim-fraction branch February 7, 2025 18:10

This was referenced Feb 10, 2025

[UI] add modal for successfully claiming a fraction #287

Closed

[claim] can't click on hypercert to view #207

Closed

github-actions bot added the released label Feb 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: batch claim fraction #378

feat: batch claim fraction #378

tnkshuuhei commented Feb 4, 2025 •

edited

Loading

vercel bot commented Feb 4, 2025 •

edited

Loading

holkexyz commented Feb 5, 2025 •

edited

Loading

tnkshuuhei commented Feb 6, 2025 •

edited

Loading

bitbeckers left a comment

tnkshuuhei commented Feb 6, 2025

Jipperism left a comment

github-actions bot commented Feb 25, 2025

feat: batch claim fraction #378

feat: batch claim fraction #378

Conversation

tnkshuuhei commented Feb 4, 2025 • edited Loading

vercel bot commented Feb 4, 2025 • edited Loading

holkexyz commented Feb 5, 2025 • edited Loading

tnkshuuhei commented Feb 6, 2025 • edited Loading

bitbeckers left a comment

Choose a reason for hiding this comment

tnkshuuhei commented Feb 6, 2025

Jipperism left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 25, 2025

tnkshuuhei commented Feb 4, 2025 •

edited

Loading

vercel bot commented Feb 4, 2025 •

edited

Loading

holkexyz commented Feb 5, 2025 •

edited

Loading

tnkshuuhei commented Feb 6, 2025 •

edited

Loading