Safe support for minting a Hypercert #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheuberger
force-pushed
the
safe-support-hypercert-minting
branch
from
45142a6 to
c858259
Compare
|
@pheuberger is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pheuberger
force-pushed
the
safe-support-hypercert-minting
branch
from
c858259 to
2d7dcc3
Compare
bitbeckers
reviewed
Mar 18, 2025
The TODOs were actually part of a WIP commit, but were not thrown out as intended after finishing the implementation.
Since it's already available in the scope, why not use it?
This feels like a reusable component but it's not. Let's improve it!
Jipperism
reviewed
Mar 25, 2025
pheuberger
force-pushed
the
safe-support-hypercert-minting
branch
from
2d7dcc3 to
b6d4ed0
Compare
Without this patch the user can only mint a Hypercert with their connected browser wallet. By passing the Safe address into the SDK function the Safe flow is invoked. The minting dialog now shows fewer steps and proposes a Safe transaction on successful signature.
It's not leading to an error, but it shouldn't be there anyway.
pheuberger
force-pushed
the
safe-support-hypercert-minting
branch
from
b6d4ed0 to
ecf41c0
Compare
Jipperism
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the user to mint a Hypercert using their Safe.
By passing the Safe address into the SDK function (via the
overridesobject) the Safe flow is invoked. The minting dialog now shows only the steps to propose a Safe transaction and invokesmintHypercert()on the Hypercerts SDK.You can see a Safe transaction that was created with the new Hypercerts SDK version and the changes from this PR here.