Skip to content

Safe support for minting a Hypercert #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pheuberger
Copy link
Member

@pheuberger pheuberger commented Mar 11, 2025

This PR adds support for the user to mint a Hypercert using their Safe.

By passing the Safe address into the SDK function (via the overrides object) the Safe flow is invoked. The minting dialog now shows only the steps to propose a Safe transaction and invokes mintHypercert() on the Hypercerts SDK.

You can see a Safe transaction that was created with the new Hypercerts SDK version and the changes from this PR here.

Copy link

vercel bot commented Mar 11, 2025

@pheuberger is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hypercerts-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 3:32pm

@pheuberger pheuberger marked this pull request as ready for review March 11, 2025 18:48
@pheuberger pheuberger force-pushed the safe-support-hypercert-minting branch from c858259 to 2d7dcc3 Compare March 11, 2025 18:49
@pheuberger pheuberger linked an issue Mar 12, 2025 that may be closed by this pull request
The TODOs were actually part of a WIP commit, but were not thrown out as
intended after finishing the implementation.
Since it's already available in the scope, why not use it?
This feels like a reusable component but it's not. Let's improve it!
Without this patch the user can only mint a Hypercert with their
connected browser wallet.

By passing the Safe address into the SDK function the Safe flow is
invoked. The minting dialog now shows fewer steps and proposes a Safe
transaction on successful signature.
It's not leading to an error, but it shouldn't be there anyway.
Copy link
Contributor

@Jipperism Jipperism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks for replying to my comments

@pheuberger pheuberger merged commit 8cee6c7 into hypercerts-org:dev Mar 25, 2025
3 checks passed
@pheuberger pheuberger deleted the safe-support-hypercert-minting branch March 25, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Safe support for minting Hypercerts
4 participants