NON-BREAKING: add org.hypercerts.claim.post lexicon #138
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hypercerts-org/lexicon": minor | ||
| --- | ||
|
|
||
| Add org.hypercerts.claim.post lexicon for updates, reports, and comments on hypercerts records | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| { | ||
| "lexicon": 1, | ||
| "id": "org.hypercerts.claim.post", | ||
| "defs": { | ||
| "main": { | ||
| "type": "record", | ||
| "description": "Record containing a hypercerts post, e.g. an update, a report, a comment.", | ||
| "key": "tid", | ||
| "record": { | ||
| "type": "object", | ||
| "required": ["createdAt"], | ||
| "properties": { | ||
| "text": { | ||
|
Contributor
There was a problem hiding this comment. The description is in opposition with |
||
| "type": "string", | ||
| "maxLength": 50000, | ||
| "maxGraphemes": 5000, | ||
| "description": "The primary post content. May be an empty string, if there are embeds." | ||
| }, | ||
| "facets": { | ||
| "type": "array", | ||
| "description": "Annotations of text (mentions, URLs, hashtags, etc.)", | ||
| "items": { "type": "ref", "ref": "app.bsky.richtext.facet" } | ||
| }, | ||
| "replies": { | ||
| "type": "array", | ||
| "description": "The subjects that this post is in reply to. Each entry identifies a thread root and the direct parent being replied to.", | ||
| "items": { "type": "ref", "ref": "#replyRef" }, | ||
| "maxLength": 10 | ||
| }, | ||
| "embed": { | ||
| "type": "union", | ||
| "description": "The primary featured media for this post (images, video, external link, or quoted record).", | ||
| "refs": [ | ||
| "app.bsky.embed.images", | ||
| "app.bsky.embed.video", | ||
| "app.bsky.embed.external", | ||
| "app.bsky.embed.record", | ||
| "app.bsky.embed.recordWithMedia" | ||
| ] | ||
| }, | ||
| "labels": { | ||
| "type": "union", | ||
| "description": "Self-label values for this post. Effectively content warnings.", | ||
| "refs": ["com.atproto.label.defs#selfLabels"] | ||
| }, | ||
| "tags": { | ||
| "type": "array", | ||
| "description": "Additional hashtags, in addition to any included in post text and facets.", | ||
| "maxLength": 8, | ||
| "items": { "type": "string", "maxLength": 640, "maxGraphemes": 64 } | ||
| }, | ||
| "attachments": { | ||
|
Contributor
There was a problem hiding this comment. and this is functionally different from embeds?
Member
Author
There was a problem hiding this comment. yes, there is just one main embed, but if you want to add just more files, you can with the attachment. |
||
| "type": "array", | ||
| "description": "The files, documents, or external references attached to this post.", | ||
| "items": { | ||
| "type": "union", | ||
| "refs": [ | ||
| "org.hypercerts.defs#uri", | ||
| "org.hypercerts.defs#smallBlob" | ||
| ] | ||
| }, | ||
| "maxLength": 100 | ||
| }, | ||
| "createdAt": { | ||
| "type": "string", | ||
| "format": "datetime", | ||
| "description": "Client-declared timestamp when this post was originally created." | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "replyRef": { | ||
| "type": "object", | ||
| "description": "Identifies the thread root and direct parent that this post is replying to.", | ||
| "required": ["root", "parent"], | ||
| "properties": { | ||
| "root": { | ||
| "type": "ref", | ||
| "ref": "com.atproto.repo.strongRef", | ||
| "description": "The root record of the thread being replied to." | ||
| }, | ||
| "parent": { | ||
| "type": "ref", | ||
| "ref": "com.atproto.repo.strongRef", | ||
| "description": "The direct parent record being replied to (may be the same as root for top-level replies)." | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+90
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# First, check if ERD.puml exists and its current state
if [ -f "ERD.puml" ]; then
echo "=== ERD.puml exists ==="
wc -l ERD.puml
echo ""
echo "=== Checking for post-related references in ERD.puml ==="
grep -n "post\|Post" ERD.puml || echo "(no 'post' references found)"
else
echo "ERD.puml does not exist"
fi
echo ""
echo "=== Checking if ERD.puml was modified in this PR ==="
git diff --name-only 2>/dev/null | head -20
echo ""
echo "=== Repository structure (checking for diagram files) ==="
find . -maxdepth 2 -name "*.puml" -o -name "*ERD*" -o -name "*erd*" 2>/dev/null | head -20Repository: hypercerts-org/hypercerts-lexicon Length of output: 411 🏁 Script executed: #!/bin/bash
# Check the git log to see recent changes to ERD.puml
echo "=== Recent git history for ERD.puml ==="
git log --oneline --all -- ERD.puml 2>/dev/null | head -10 || echo "No git history available"
echo ""
echo "=== Files in the repository root ==="
ls -la | head -30Repository: hypercerts-org/hypercerts-lexicon Length of output: 2522 🏁 Script executed: #!/bin/bash
# Read the ERD.puml file to see its current structure
echo "=== ERD.puml content ==="
cat -n ERD.pumlRepository: hypercerts-org/hypercerts-lexicon Length of output: 9787 🏁 Script executed: #!/bin/bash
# Check the git diff for the commit that added post.json to see if ERD.puml was modified
echo "=== Git diff for d597c87 (post.json commit) ==="
git show d597c87 --stat
echo ""
echo "=== Did post.json commit touch ERD.puml? ==="
git show d597c87 --name-only | grep -i "erd\|post"Repository: hypercerts-org/hypercerts-lexicon Length of output: 7447 Add The new 🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the
.claim.domain because this can point to many things, including evidence, that aren't directly the claimThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I feel like the whole folder structure isn't super ideal yet, but don't have a very clear alternative.
regarding evidence, that is claim.attachment, so claim.post would for that. I agree with you in general though... will think about the folder structure more