Safe allowlist minting #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
The name of the method was too specific since it's a fairly generic method. It will be used by the claim function that is going to be introduced in the next commit.
Akin to the mintHypercert method, enable the claimFractionFromAllowlist() method to follow the same pattern.
There were some uncovered lines in the constructor.
pheuberger
force-pushed
the
safe-allowlist-minting
branch
from
85ee7a7 to
17b89bf
Compare
This was referenced Mar 25, 2025
Jipperism
approved these changes
Mar 25, 2025
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
overrides.safeAddressto theclaimFractionFromAllowlist()method to submit the transaction to the Safe app.This is using the same pattern as the
mintHypercert()method.Example transaction created using this code: https://app.safe.global/transactions/tx?safe=sep:0x6C622Ca31a755b4A543f1FE1dB26A666A468Fda8&id=multisig_0x6C622Ca31a755b4A543f1FE1dB26A666A468Fda8_0x4ceecae4047d731de541d672b864b5ef930a845df2e79713231f43cbdf974cd8