Safe integration for creating marketplace listings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our frontend we're using Hypercerts as name and version number 1, so we should do this in our SDK as well.
The TSDoc around bundleApprovalsForSafe() was missing a parameter and not very descriptive what it did.
pheuberger
force-pushed
the
listing-safe-integration
branch
from
997b366 to
eb41f3e
Compare
Without this patch users of this SDK have no way to create marketplace listings from a Safe. This new function signs a maker order and uploads it to the Safe transaction service. There it can be executed by the other signers.
The function doesn't need these fields to compute validity. This only complicates things at the call-site. We should apply the Law of Demeter here.
Without this patch there's only the option to send both approval transactions in a bundle. This can be a problem when the Safe has one of the approvals but not both. Surely this is an edge case, but it did happen during development. The problem, here, is that the approval of the transfer manager will reject if it's already done. This could lead to users being stuck.
This function builds the Safe-specific payload to the API that only contains the chain id and message hash.
pheuberger
force-pushed
the
listing-safe-integration
branch
from
eb41f3e to
76fb5c3
Compare
Jipperism
requested changes
Apr 8, 2025
| return this.createMakerAsk({ | ||
| // Defaults | ||
| strategyId: StrategyType.standard, | ||
| collectionType: 2, |
There was a problem hiding this comment.
we could use the CollectionType enum here
| @@ -2,11 +2,11 @@ | |||
| * EIP712 domain name. | |||
| * @see {@link https://eips.ethereum.org/EIPS/eip-712#definition-of-domainseparator EIP712 doc} | |||
| */ | |||
| export const DOMAIN_NAME = "LooksRareProtocol"; | |||
| export const DOMAIN_NAME = "Hypercerts"; | |||
There was a problem hiding this comment.
this was changed last time as well, and it broke signatures as the API needs to be updated too, so I rolled it back. if we want to change it, it needs to be rolled out at the same time for the API and the marketplace sdk
|
|
||
| /** | ||
| * EIP712 domain version. | ||
| * @see {@link https://eips.ethereum.org/EIPS/eip-712#definition-of-domainseparator EIP712 doc} | ||
| */ | ||
| export const DOMAIN_VERSION = 2; | ||
| export const DOMAIN_VERSION = 1; |
| const domain = { | ||
| name: DOMAIN_NAME, | ||
| version: DOMAIN_VERSION.toString(), | ||
| chainId: Number(this.chainId), |
| safeAddress: this.address, | ||
| }); | ||
|
|
||
| const domain = { |
There was a problem hiding this comment.
There is getTypedDataDomain()
Jipperism
reviewed
Apr 8, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@hypercerts-org/marketplace-sdk", | |||
| "version": "0.5.3", | |||
| "version": "0.5.4", | |||
There was a problem hiding this comment.
i just merged the other PR so this needs updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to create marketplace listings using a Safe.
It introduces a new class
SafeMessagesthat deals with constructing, signing and uploading Safe messages to the Safe Transaction Service.On the exchange client it introduces a new function
signMakerOrderSafe()that's supposed to be called by the users of this SDK.