feat: basic batchTransfer function

[tnkshuuhei]

No description provided.

[github-actions]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• shadowing-local (2 results) (Low)
• calls-loop (2 results) (Low)
• unused-state (1 results) (Informational)
• immutable-states (1 results) (Optimization)

shadowing-local

Impact: Low
Confidence: High

• ID-0
  IHypercertToken.mintClaimWithFractions(address,uint256,uint256[],string,IHypercertToken.TransferRestrictions).uri shadows:
  • IHypercertToken.uri(uint256) (function)

protocol-periphery/src/interfaces/IHypercertToken.sol

Line 29 in bfe82cc

string memory uri,

• ID-1
  IHypercertToken.mintClaim(address,uint256,string,IHypercertToken.TransferRestrictions).uri shadows:
  • IHypercertToken.uri(uint256) (function)

protocol-periphery/src/interfaces/IHypercertToken.sol

Line 21 in bfe82cc

function mintClaim(address account, uint256 units, string memory uri, TransferRestrictions restrictions) external;

calls-loop

Impact: Low
Confidence: Medium

• ID-2
  BatchTransferFraction.batchTransfer(bytes) has external calls inside a loop: require(bool,error)(hypercertToken.ownerOf(fractionId) == msg.sender,revert INVALID_CALLER(address)(msg.sender))

protocol-periphery/src/BatchTransferFraction.sol

Lines 26 to 38 in bfe82cc

	function batchTransfer(bytes memory data) external {
	require(data.length > 0, INVALID_DATA());
	TransferData memory transferData = abi.decode(data, (TransferData));
	require(transferData.recipients.length == transferData.fractionIds.length, INVALID_LENGTHS());
	for (uint256 i = 0; i < transferData.recipients.length; i++) {
	address recipient = transferData.recipients[i];
	uint256 fractionId = transferData.fractionIds[i];
	require(hypercertToken.ownerOf(fractionId) == msg.sender, INVALID_CALLER(msg.sender));
	hypercertToken.safeTransferFrom(msg.sender, recipient, fractionId, 1, "");
	}
	}

• ID-3
  BatchTransferFraction.batchTransfer(bytes) has external calls inside a loop: hypercertToken.safeTransferFrom(msg.sender,recipient,fractionId,1,)

protocol-periphery/src/BatchTransferFraction.sol

Lines 26 to 38 in bfe82cc

	function batchTransfer(bytes memory data) external {
	require(data.length > 0, INVALID_DATA());
	TransferData memory transferData = abi.decode(data, (TransferData));
	require(transferData.recipients.length == transferData.fractionIds.length, INVALID_LENGTHS());
	for (uint256 i = 0; i < transferData.recipients.length; i++) {
	address recipient = transferData.recipients[i];
	uint256 fractionId = transferData.fractionIds[i];
	require(hypercertToken.ownerOf(fractionId) == msg.sender, INVALID_CALLER(msg.sender));
	hypercertToken.safeTransferFrom(msg.sender, recipient, fractionId, 1, "");
	}
	}

unused-state

Impact: Informational
Confidence: High

• ID-4
  BatchTransferFraction.FRACTION_LIMIT is never used in BatchTransferFraction

protocol-periphery/src/BatchTransferFraction.sol

Line 8 in bfe82cc

uint256 internal constant FRACTION_LIMIT = 253;

immutable-states

Impact: Optimization
Confidence: High

• ID-5
  BatchTransferFraction.hypercertToken should be immutable

protocol-periphery/src/BatchTransferFraction.sol

Line 7 in bfe82cc

IHypercertToken public hypercertToken;

[github-actions]

Coverage after merging feat/batchTransfer into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
BatchTransferFraction.sol	100%	100%	100%	100%