Skip to content

Comments

fix : Support JSON type in Surrounding Context. #1652

Open
Rajin9601 wants to merge 3 commits intohyperdxio:mainfrom
Rajin9601:rajin/260126-support-json
Open

fix : Support JSON type in Surrounding Context. #1652
Rajin9601 wants to merge 3 commits intohyperdxio:mainfrom
Rajin9601:rajin/260126-support-json

Conversation

@Rajin9601
Copy link

to resolve #983

This issue was closed as not planned, but I think the solution is simple enough that it should be considered for merging.

row data has __hdx_resource_attributes (which is ROW_DATA_ALIASES.RESOURCE_ATTRIBUTES) and it is flattened so that it could be used for both map and json type.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 37bfebc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 26, 2026

@Rajin9601 is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@karl-power karl-power self-requested a review February 18, 2026 14:58
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 20, 2026 4:01pm

Request Review

@github-actions
Copy link
Contributor

Claude Code Review

✅ No critical issues found.

The fix correctly replaces the hardcoded ResourceAttributes key with ROW_DATA_ALIASES.RESOURCE_ATTRIBUTES (__hdx_resource_attributes), consistent with how the rest of ContextSidePanel.tsx accesses row data (e.g., line 81 already uses ROW_DATA_ALIASES.TIMESTAMP). This ensures the destructuring works for both map and JSON column types as described in the PR.

@karl-power
Copy link
Contributor

Looks good @Rajin9601

Can you please run yarn changeset and commit the file that's created?

@teeohhem
Copy link
Contributor

Thanks for the submission! We're testing the JSON experience holistically and will respond with a final review next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surrounding context unable to filter on Pod or Node when using JSON columns

3 participants