fix: resolve "no query support for metric type" error in external API#1708
Open
Bre77 wants to merge 3 commits intohyperdxio:mainfrom
Open
fix: resolve "no query support for metric type" error in external API#1708Bre77 wants to merge 3 commits intohyperdxio:mainfrom
Bre77 wants to merge 3 commits intohyperdxio:mainfrom
Conversation
|
@Bre77 is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: b946049 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pulpdrew
reviewed
Feb 19, 2026
Contributor
pulpdrew
left a comment
pulpdrew
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Two minor comments but overall LGTM.
Contributor
PR Review✅ No critical issues found. Logic is correct:
Validation is fine:
Test coverage is solid (gauge, sum, histogram, and backward-compat). Changeset included. Good to merge. 🤖 Generated with Claude Code |
When querying metrics via POST /api/v2/charts/series, passing the metric name as `field` without also setting `metricName` caused the query to fail because translateMetricChartConfig() requires metricName to be set. Now the external API falls back to using `field` as the metric name when `metricName` is not provided, and defaults valueExpression to 'Value' (the ClickHouse column), matching how the dashboard UI builds configs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add test verifying metricName takes precedence over field when both are provided, and fix lint formatting in ternary expressions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bre77
force-pushed
the
fix/metrics-api-field-as-metric-name
branch
from
e7c2c49 to
b946049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v2/charts/seriesreturning"no query support for metric type=gauge"whenfieldis passed withoutmetricNamefieldas themetricNameand defaultsvalueExpressionto'Value'(the ClickHouse column), matching how the dashboard UI builds chart configsmetricNameandfieldare provided, behavior is unchangedRoot Cause
buildChartConfigFromRequest()mappedfieldtovalueExpressionbut never populatedmetricNamefrom it. Downstream,translateMetricChartConfig()requires bothmetricTypeANDmetricNameto be truthy — whenmetricNamewas undefined, it fell through to the catch-all error.Test plan
fieldwithoutmetricNamemetricNameandfieldworks as before)Related: #1418, #1214
🤖 Generated with Claude Code