-
Notifications
You must be signed in to change notification settings - Fork 368
feat(alerts): add scheduleStartAt + scheduleOffsetMinutes #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlsalcedo
wants to merge
27
commits into
hyperdxio:main
Choose a base branch
from
mlsalcedo:startTime-offset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,182
−38
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c1b8292
feat: add support for `scheduleStartAt` and `scheduleOffsetMinutes` i…
melsalcedo ffa5bf2
Update packages/api/src/controllers/alerts.ts
mlsalcedo 7f1506c
Update packages/api/src/controllers/alerts.ts
mlsalcedo 8408688
refactor: simplify `scheduleStartAt` validation using `fns.isValid` f…
melsalcedo bf4b847
feat: improve alert scheduling by updating `scheduleStartAt` validati…
melsalcedo 799c84c
Merge branch 'main' into startTime-offset
teeohhem 03c07cb
refactor(alerts): dedupe interval and offset validation
melsalcedo f8b379e
feat(app): use DateTimePicker for scheduleStartAt input
melsalcedo ea4ab24
feat(app): add datetime picker to dashboard alert start time
melsalcedo dfadc7e
refactor(alerts): share scheduleStartAt schema and parser
melsalcedo b903e61
chore(alerts): clarify anchor start label in forms
melsalcedo d1a028d
fix(alerts): handle null scheduleStartAt and add scheduling guards
melsalcedo 29af34b
chore(alerts): address review feedback for schedule start
melsalcedo 30c4865
chore(alerts): normalize schedule defaults and 1m offset UX
melsalcedo 32a7267
refactor(alerts): centralize schedule fields and harden API validation
melsalcedo 539b531
fix(alerts): avoid no-op schedule writes for existing alerts
melsalcedo 41e0c26
refactor(alerts): share no-op schedule normalization helper
melsalcedo 6e31044
fix(alerts): tighten scheduleStartAt validation and defaults
melsalcedo d1498fc
fix(alerts): guard new-alert schedule normalization
melsalcedo fe52938
chore(alerts): tighten copy and offset bounds
melsalcedo f7cceef
chore(alerts): clarify offset behavior with anchored start
melsalcedo 6a4c407
chore(alerts): guard anchor bounds and document zod coupling
melsalcedo be098f9
feat(alerts): enforce anchored offset semantics across layers
melsalcedo 7d502a2
fix(alerts): clear stale offset when scheduleStartAt is set
melsalcedo e718023
fix(alerts): preserve schema compatibility and harden no-op normaliza…
melsalcedo 6c96d66
fix(common-utils): keep validated alert schemas internal
melsalcedo 2d29bb5
fix(alerts): tighten external validation and clear stale offsets
melsalcedo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.