Skip to content

chore: Raise TIER2_MAX_LINES threshold from 150 to 250#2183

Open
Copilot wants to merge 2 commits intomainfrom
copilot/adjust-pr-tier-level
Open

chore: Raise TIER2_MAX_LINES threshold from 150 to 250#2183
Copilot wants to merge 2 commits intomainfrom
copilot/adjust-pr-tier-level

Conversation

Copy link
Copy Markdown

Copilot AI commented May 1, 2026 •
edited
Loading

  • Add a Diff size trigger in buildTierComment for Tier 3 when prodLines >= TIER2_MAX_LINES
  • Add a test for the new trigger in pr-triage-classify.test.js

@teeohhem
raise TIER2_MAX_LINES from 150 to 250 to correctly classify focused U…
ff1458a 
…I component PRs

Agent-Logs-Url: https://github.com/hyperdxio/hyperdx/sessions/8be8d1a1-7a99-451d-8a38-94db56fd52ba

Co-authored-by: teeohhem <3245235+teeohhem@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 1, 2026 4:47am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 1, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6b42032

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teeohhem teeohhem marked this pull request as ready for review May 1, 2026 04:42
@teeohhem teeohhem changed the title Raise TIER2_MAX_LINES threshold from 150 to 250 chore: Raise TIER2_MAX_LINES threshold from 150 to 250 May 1, 2026
@github-actions github-actions Bot added the review/tier-1 Trivial — auto-merge candidate once CI passes label May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026 •
edited
Loading

🟢 Tier 1 — Trivial

Docs, images, lock files, or a dependency bump. No functional code changes detected.

Why this tier:

  • All files are docs / images / lock files

Review process: Auto-merge once CI passes. No human review required.
SLA: Resolves automatically.

Stats
  • Production files changed: 0
  • Production lines changed: 0 (+ 25 in test files, excluded from tier calculation)
  • Branch: copilot/adjust-pr-tier-level
  • Author: Copilot

To override this classification, remove the review/tier-1 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

PR Review

✅ No critical issues found.

Summary: Simple threshold bump in pr-triage-classify.js (TIER2_MAX_LINES: 150 → 250), motivated by a concrete misclassification of PR #2175 (238-line pure UI component forced to Tier 3).

Notes:

  • Logic at line 159 uses strict <, so the boundary is correctly exclusive: 249 lines → Tier 2, 250 lines → Tier 3. Tests confirm this correctly.
  • The comment fix in the existing test (> TIER2_MAX_LINES (150) → >= TIER2_MAX_LINES (250)) is a good accuracy improvement — 250 lines equals the threshold, not exceeds it.
  • AGENT_TIER2_MAX_LINES = 50 (agent branches) is unaffected and remains stricter, which is the right asymmetry.
  • Both changed files live under .github/scripts/, which the classifier itself marks as Tier 1 — the Tier 1 label on this PR is consistent with that rule.

Copilot AI requested a review from teeohhem May 1, 2026 04:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 158 passed • 3 skipped • 1168s

Status Count
✅ Passed 158
❌ Failed 0
⚠️ Flaky 5
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teeohhem teeohhem teeohhem approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@teeohhem teeohhem

Copilot code review Copilot

Labels

automerge review/tier-1 Trivial — auto-merge candidate once CI passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teeohhem