Updating RuleEntry.Evaluate error logging to include value returned by recover. #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
After fighting with my sickness, Im ready continue on and return to accepting changes. Im sorry for this and thank you for your contribution. |
JoshKoberstein
force-pushed
the
ast-evaluate-recover-logging
branch
from
387d7ed to
532960b
Compare
Contributor
Author
|
Hi @newm4n ! I am sorry to hear about your sickness and am glad you are feeling better. I have updated my branch. Thank you for reviewing. |
newm4n
approved these changes
Jul 1, 2025
Collaborator
|
I've merge it in. Will be included on the next Release. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make troubleshooting of rule entries that panic during evaluation easier, I have update the error message to include the value returned by recover. This logging of
ris being done in theExecutemethod on line 208 so I used this line as an example and followed the same format.