fix: solana routing fee (#8599)

Author: troykessler

.changeset/brown-peaches-peel.md

@@ -0,0 +1,5 @@
+---
+"@hyperlane-xyz/sdk": patch
+---
+
+Fixed routing fee for non-evm legs

typescript/cli/src/tests/cross-chain/warp/warp-cc-evm-svm.e2e-test.ts

@@ -21,6 +21,7 @@ import {
   runSolanaNode,
 } from '@hyperlane-xyz/sealevel-sdk/testing';
 import {
+  TokenFeeType,
   TokenType,
   type WarpCoreConfig,
   type WarpRouteDeployConfig,
@@ -355,4 +356,75 @@ describe('hyperlane warp crossCollateral EVM+SVM e2e tests', function () {
       `EVM Route B should have EVM Route A enrolled as CC router on domain ${evmDomainId}`,
     ).to.include(evmRouterAHex32);
   });
+
+  it('should deploy EVM collateral + SVM synthetic with RoutingFee tokenFee without error', async function () {
+    const evmOwner = new Wallet(EVM_KEY).address;
+    const svmOwner = svmSigner.getSignerAddress();
+    const DECIMALS = 9;
+    const SYMBOL = 'RTKN';
+
+    const evmToken = await deployToken(
+      EVM_KEY,
+      EVM_CHAIN,
+      DECIMALS,
+      SYMBOL,
+      'Routing Token',
+      REGISTRY_PATH,
+    );
+
+    const warpId = createWarpRouteConfigId(SYMBOL, `${EVM_CHAIN}-${SVM_CHAIN}`);
+    const warpDeployConfig: WarpRouteDeployConfig = {
+      [EVM_CHAIN]: {
+        type: TokenType.collateral,
+        token: evmToken.address,
+        mailbox: evmCoreAddresses.mailbox,
+        owner: evmOwner,
+        tokenFee: {
+          type: TokenFeeType.RoutingFee,
+          owner: evmOwner,
+          feeContracts: {
+            [SVM_CHAIN]: {
+              type: TokenFeeType.LinearFee,
+              bps: 50,
+            },
+          },
+        },
+      },
+      [SVM_CHAIN]: {
+        type: TokenType.synthetic,
+        mailbox: svmCoreAddresses.mailbox,
+        owner: svmOwner,
+        name: 'Routing Token',
+        symbol: SYMBOL,
+        decimals: DECIMALS,
+        metadataUri: 'https://test.example.com/rtkn-metadata.json',
+      },
+    };
+
+    writeYamlOrJson(WARP_DEPLOY_OUTPUT_PATH, warpDeployConfig);
+
+    // Before the fix, enrollCrossChainRouters would fail with a
+    // RoutingFeeInputConfigSchema validation error because the EVM reader
+    // returns empty feeContracts when no SVM routers are enrolled yet.
+    await warpCommands.deployRaw({
+      warpRouteId: warpId,
+      warpDeployPath: WARP_DEPLOY_OUTPUT_PATH,
+      skipConfirmationPrompts: true,
+      extraArgs: [
+        `--key.${ProtocolType.Ethereum}`,
+        EVM_KEY,
+        `--key.${ProtocolType.Sealevel}`,
+        SVM_KEY,
+      ],
+    });
+
+    const warpCorePath = getWarpCoreConfigPath(SYMBOL, [EVM_CHAIN, SVM_CHAIN]);
+    const deployedConfig = await warpCommands.readConfig(
+      EVM_CHAIN,
+      warpCorePath,
+    );
+    expect(deployedConfig[EVM_CHAIN].tokenFee?.type).to.equal(
+      TokenFeeType.RoutingFee,
+    );
+  });
 });

typescript/sdk/src/deploy/warp.ts

@@ -645,6 +645,17 @@ export async function enrollCrossChainRouters(
             owner: resolvedConfigMap[currentChain].owner,
             remoteRouters,
             destinationGas,
+            // For cross-protocol routes (EVM+SVM/Cosmos), the EVM deployer
+            // never enrolls non-EVM remote routers, so TokenRouter.domains()=[]
+            // at this point. The reader derives RoutingFee.feeContracts from
+            // enrolled domains, returning {} which fails
+            // RoutingFeeInputConfigSchema validation. Use the deploy config's
+            // tokenFee (non-empty feeContracts) so validation passes.
+            // EvmTokenFeeModule.update() reads actual on-chain state via
+            // routingDestinations and confirms no change is needed.
+            ...(resolvedConfigMap[currentChain].tokenFee && {
+              tokenFee: resolvedConfigMap[currentChain].tokenFee,
+            }),
           };
 
           transactions = await evmWarpModule.update(expectedConfig, {