feat: easy RPC configuration for agents for all chains#5834
Closed
mkykadir wants to merge 6 commits intohyperlane-xyz:mainfrom
Closed
feat: easy RPC configuration for agents for all chains#5834mkykadir wants to merge 6 commits intohyperlane-xyz:mainfrom
mkykadir wants to merge 6 commits intohyperlane-xyz:mainfrom
Conversation
|
Contributor
Author
|
Docs PR hyperlane-xyz/v3-docs#377 |
Contributor
Author
|
updated with latest main |
Contributor
Author
|
closing this that I dont have enough time to keep it updated with recent changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new common configuration field
rpcUrlswhich is a string argument expecting list of comma separated RPC URLs. Regardless of chains, any chain RPC URL can be provided in list and while configuration is loaded each RPC will be queried for its chain id so its utilized within related chain configuration.This makes configuration very easy, especially for automated deployment environments.
Drive-by changes
Configuration loading is now async
Related issues
NA
Backward compatibility
Changes are backward compatible. Common
rpcUrlsfield is optional, when provided URL preferred over chain specific fields so that its easy to configure RPC URLs by default. If common (new) field is not provided RPC URL configuration works as usual.Testing
Manual,
rpcUrlsprovided and tested