Skip to content

feat: Starknet core artifact generation tests [STARKNET-04]#5957

Open
ljankovic-txfusion wants to merge 19 commits intohyperlane-xyz:mainfrom
txfusion:feat/starknet-generate-artifacts-test
Open

feat: Starknet core artifact generation tests [STARKNET-04]#5957
ljankovic-txfusion wants to merge 19 commits intohyperlane-xyz:mainfrom
txfusion:feat/starknet-generate-artifacts-test

Conversation

@ljankovic-txfusion
Copy link
Copy Markdown
Contributor

Description

4th Starknet PR

This PR adds StarknetArtifactGeneration and Templates tests

Diff with previous PR - feat: Starknet SDK logic integration #5838

Drive-by changes

General refactoring of artifact generation logic

Related issues

Resolves ENG-1309

Backward compatibility

Yes

Testing

Yes, added test cases for starknet artifact generation

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2025

🦋 Changeset detected

Latest commit: dd41726

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/starknet-core Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/cosmos-sdk Minor
@hyperlane-xyz/cosmos-types Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (8601b16) to head (2d234e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5957   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files         110      110           
  Lines        2166     2166           
  Branches      196      196           
=======================================
  Hits         1667     1667           
  Misses        478      478           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 78.14% <ø> (ø)
isms 81.72% <ø> (ø)
token 90.54% <ø> (ø)
middlewares 79.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread starknet/scripts/fetch-contracts-release.sh Outdated
Comment thread typescript/sdk/src/providers/MultiProvider.ts
@ljankovic-txfusion ljankovic-txfusion force-pushed the feat/starknet-generate-artifacts-test branch from 9af9267 to 516c6c9 Compare May 9, 2025 09:53
Comment on lines +189 to +191
override getBridgedSupply(): Promise<bigint | undefined> {
return this.getBalance(this.addresses.warpRouter);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getBridgedSupply method is marked with override but is missing the async keyword, while the base class method is asynchronous. To properly override the base class method, it should be declared as:

override async getBridgedSupply(): Promise<bigint | undefined> {
  return this.getBalance(this.addresses.warpRouter);
}

This ensures the method signature correctly matches the parent class implementation.

Suggested change
override getBridgedSupply(): Promise<bigint | undefined> {
return this.getBalance(this.addresses.warpRouter);
}
override async getBridgedSupply(): Promise<bigint | undefined> {
return this.getBalance(this.addresses.warpRouter);
}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Comment thread starknet/.mocharc.json
@@ -0,0 +1,5 @@
{
"extensions": ["ts"],
"spec": ["src/**/*.test.*"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mocha configuration in .mocharc.json specifies "spec": ["src/**/*.test.*"], but the test files are located in the tests/ directory. This mismatch will prevent Mocha from finding any test files when running the test command.

Consider updating the spec pattern to "tests/**/*.test.*" to correctly target the test files in their actual location.

Suggested change
"spec": ["src/**/*.test.*"],
+ "spec": ["tests/**/*.test.*"],

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant