feat: Starknet core artifact generation tests [STARKNET-04]#5957
feat: Starknet core artifact generation tests [STARKNET-04]#5957ljankovic-txfusion wants to merge 19 commits intohyperlane-xyz:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dd41726 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5957 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 110 110
Lines 2166 2166
Branches 196 196
=======================================
Hits 1667 1667
Misses 478 478
Partials 21 21
🚀 New features to boost your workflow:
|
9af9267 to
516c6c9
Compare
…into feat/starknet-utils
…tarknet-sdk-integration
…nto feat/starknet-generate-artifacts-test
…into feat/starknet-utils
…tarknet-sdk-integration
…nto feat/starknet-generate-artifacts-test
…tarknet-sdk-integration
…nto feat/starknet-generate-artifacts-test
…tarknet-sdk-integration
…nto feat/starknet-generate-artifacts-test
| override getBridgedSupply(): Promise<bigint | undefined> { | ||
| return this.getBalance(this.addresses.warpRouter); | ||
| } |
There was a problem hiding this comment.
The getBridgedSupply method is marked with override but is missing the async keyword, while the base class method is asynchronous. To properly override the base class method, it should be declared as:
override async getBridgedSupply(): Promise<bigint | undefined> {
return this.getBalance(this.addresses.warpRouter);
}This ensures the method signature correctly matches the parent class implementation.
| override getBridgedSupply(): Promise<bigint | undefined> { | |
| return this.getBalance(this.addresses.warpRouter); | |
| } | |
| override async getBridgedSupply(): Promise<bigint | undefined> { | |
| return this.getBalance(this.addresses.warpRouter); | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "extensions": ["ts"], | |||
| "spec": ["src/**/*.test.*"], | |||
There was a problem hiding this comment.
The Mocha configuration in .mocharc.json specifies "spec": ["src/**/*.test.*"], but the test files are located in the tests/ directory. This mismatch will prevent Mocha from finding any test files when running the test command.
Consider updating the spec pattern to "tests/**/*.test.*" to correctly target the test files in their actual location.
| "spec": ["src/**/*.test.*"], | |
| + "spec": ["tests/**/*.test.*"], |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Description
4th Starknet PR
This PR adds
StarknetArtifactGenerationandTemplatestestsDiff with previous PR - feat: Starknet SDK logic integration #5838
Drive-by changes
General refactoring of artifact generation logic
Related issues
Resolves ENG-1309
Backward compatibility
Yes
Testing
Yes, added test cases for starknet artifact generation