Skip to content

feat(scraper): Add span to cursor indexer task#7232

Merged
ameten merged 1 commit intomainfrom
ameten/scraper-add-span-with-label
Oct 21, 2025
Merged

feat(scraper): Add span to cursor indexer task#7232
ameten merged 1 commit intomainfrom
ameten/scraper-add-span-with-label

Conversation

@ameten
Copy link
Copy Markdown
Contributor

@ameten ameten commented Oct 21, 2025

Summary

  • Added tracing span to the spawned cursor indexer task in the scraper

Details

This change improves observability by adding a labeled span around the cursor_indexer_task when it's spawned. The span includes:

  • Domain name
  • Label (e.g., "message", "interchain_gas_payment")

This makes it easier to trace and debug scraper tasks in the logs and helps identify which specific task is running.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced internal tracing and monitoring infrastructure to provide improved system observability and task-level diagnostics.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: c12dab8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

Enhanced observability for task spawning in the contract sync module by adding tracing instrumentation. The cursor_indexer_task spawn wraps its async block with an instrumented info_span that includes domain and label fields, improving per-task tracing capabilities without altering core task logic.

Changes

Cohort / File(s) Summary
Tracing instrumentation enhancement
rust/main/hyperlane-base/src/contract_sync/mod.rs
Added Instrument to tracing imports; enhanced ContractSync instrumentation attribute with a label field; wrapped cursor_indexer_task spawn with instrumented info_span for improved per-task observability

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

The changes are localized to a single file with straightforward instrumentation additions. The modifications follow established tracing patterns and don't alter core functionality—mainly wrapping existing code with observability layers.

Possibly related PRs

Suggested reviewers

  • tkporter
  • kamiyaa

Poem

🧅 Like layers on an onion, the tracing goes deep,
Each task now whispers its secrets to keep,
Domain and label dance in the span,
Observability flows like a well-hatched plan—
No ogres here, just better to see,
What happens inside, so faithfully! 🔍

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description provides a clear summary and details about the tracing improvements being made to the cursor indexer task, which is helpful for understanding the change's purpose. However, the description doesn't align with the repository's required template structure. Several key sections are missing entirely, including explicit sections for backward compatibility assessment, testing information, drive-by changes, and related issues. While the description isn't empty or completely off-topic, it lacks the structured information that the template requires reviewers to have before merging. The author should update the PR description to follow the template structure by adding sections for: (1) a Related issues section linking to the PR number or any associated issues, (2) a Backward compatibility section explaining whether these changes maintain compatibility, (3) a Testing section describing what testing was performed (the objectives mention running the scraper locally to verify spans appear), and (4) a Drive-by changes section if there are any additional modifications beyond the main scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "feat(scraper): Add span to cursor indexer task" directly and clearly captures the main change in the PR. The changeset centers on adding a tracing span with an instrumented info_span around the cursor_indexer_task spawn, which is exactly what the title communicates. It's concise, specific, and anyone reviewing the git history would immediately understand what this change does without needing extra details.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ameten/scraper-add-span-with-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ameten ameten added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 3699918 Oct 21, 2025
41 checks passed
@ameten ameten deleted the ameten/scraper-add-span-with-label branch October 21, 2025 13:51
@github-project-automation github-project-automation Bot moved this from In Review to Done in Hyperlane Tasks Oct 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7d6a86b) to head (c12dab8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #7232   +/-   ##
=====================================
  Coverage   0.00%       0           
=====================================
  Files          1       0    -1     
  Lines         14       0   -14     
=====================================
+ Misses        14       0   -14     
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Oct 29, 2025
This was referenced Nov 5, 2025
danwt pushed a commit to dymensionxyz/hyperlane-monorepo that referenced this pull request Dec 12, 2025
Co-authored-by: Danil Nemirovsky <4614623+ameten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants