Skip to content

feat: cherry-pick MinimalInterchainAccountRouter solidity changes#8367

Merged
paulbalaji merged 2 commits intoaudit-q2-2026from
cherry-pick-minimal-ica-solidity
Mar 19, 2026
Merged

feat: cherry-pick MinimalInterchainAccountRouter solidity changes#8367
paulbalaji merged 2 commits intoaudit-q2-2026from
cherry-pick-minimal-ica-solidity

Conversation

@paulbalaji
Copy link
Copy Markdown
Collaborator

@paulbalaji paulbalaji commented Mar 18, 2026

Summary

Notes

  • MinimalInterchainAccountRouter intentionally omits commit-reveal / CCIP-read behavior and the CommitmentReadIsm sub-deployment
  • CREATE2 ICA derivation is intentionally unchanged so accounts created through the full and minimal routers remain interoperable

Validation

  • pnpm -C solidity test:forge --match-path test/InterchainAccountRouter.t.sol
  • pnpm -C solidity test:forge --match-path test/MinimalInterchainAccountRouter.t.sol

Cherry-picked solidity changes from 6c715a7 (#8323):
- Extract AbstractInterchainAccountRouter base contract
- Add MinimalInterchainAccountRouter for Igra
- Refactor InterchainAccountRouter to extend abstract base
- Update and add tests
cursor[bot]

This comment was marked as resolved.

@paulbalaji paulbalaji marked this pull request as ready for review March 18, 2026 14:55
@paulbalaji paulbalaji requested a review from yorhodes as a code owner March 18, 2026 14:55
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 18, 2026

Warning

Rate limit exceeded

@paulbalaji has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 549f63ef-5b98-4b4f-a749-fe9869a36dbc

📥 Commits

Reviewing files that changed from the base of the PR and between d41d088 and 92b705b.

📒 Files selected for processing (6)
  • .changeset/slim-ica-core.md
  • solidity/contracts/middleware/AbstractInterchainAccountRouter.sol
  • solidity/contracts/middleware/InterchainAccountRouter.sol
  • solidity/contracts/middleware/MinimalInterchainAccountRouter.sol
  • solidity/test/InterchainAccountRouter.t.sol
  • solidity/test/MinimalInterchainAccountRouter.t.sol
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.21%. Comparing base (d41d088) to head (92b705b).
⚠️ Report is 1 commits behind head on audit-q2-2026.

Additional details and impacted files
@@                Coverage Diff                @@
##           audit-q2-2026    #8367      +/-   ##
=================================================
+ Coverage          75.82%   77.21%   +1.39%     
=================================================
  Files                124      131       +7     
  Lines               3069     3366     +297     
  Branches             253      299      +46     
=================================================
+ Hits                2327     2599     +272     
- Misses               726      750      +24     
- Partials              16       17       +1     
Flag Coverage Δ
solidity 78.47% <93.82%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 87.80% <ø> (ø)
hooks 74.55% <ø> (+2.71%) ⬆️
isms 81.46% <ø> (+0.45%) ⬆️
token 86.91% <ø> (+0.28%) ⬆️
middlewares 87.87% <93.82%> (+2.89%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

@paulbalaji paulbalaji enabled auto-merge (squash) March 19, 2026 19:45
@paulbalaji paulbalaji merged commit 993de2b into audit-q2-2026 Mar 19, 2026
234 of 236 checks passed
@paulbalaji paulbalaji deleted the cherry-pick-minimal-ica-solidity branch March 19, 2026 19:47
@github-project-automation github-project-automation Bot moved this from In Review to Done in Hyperlane Tasks Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants