feat(infra): USDT OFT warp route deployment + SDK fix for unproxied contracts#8507
Draft
Mo-Hussain wants to merge 3 commits intoaudit-q2-2026from
Draft
feat(infra): USDT OFT warp route deployment + SDK fix for unproxied contracts#8507Mo-Hussain wants to merge 3 commits intoaudit-q2-2026from
Mo-Hussain wants to merge 3 commits intoaudit-q2-2026from
Conversation
EvmWarpModule.createHookUpdateTxs() asserted proxyAdmin exists even for unproxied collateralOft contracts. The EvmWarpRouteReader sets hook to AddressZero as a sentinel for OFT/deposit-address contracts, but AddressZero is truthy so the early-return check did not fire. Now treats AddressZero hook as empty, matching the sentinel pattern.
Added collateralOft config getter for USDT/oft warp route across ethereum, arbitrum, and plasma using LayerZero OFT bridge contracts. Contracts deployed: - arbitrum: 0xE4c1A1E54C232454311cF68610c3885FdD991c0E - ethereum: 0x7Bb4fe8f406fB7B22487Fa2e3BCbCb6A38cF29E6 - plasma: 0x93bfFA2231fbA5029997603fb68D9aC08024Baa2
1 task
nambrot
approved these changes
Apr 1, 2026
| chain, | ||
| { | ||
| ...routerConfig[chain], | ||
| owner: deployerAddress, |
Collaborator
Author
There was a problem hiding this comment.
yep will be transferring ownership
| expectedConfig: HypTokenRouterConfig, | ||
| ): Promise<AnnotatedEV5Transaction[]> { | ||
| if (!expectedConfig.hook) { | ||
| if (!expectedConfig.hook || expectedConfig.hook === constants.AddressZero) { |
Contributor
There was a problem hiding this comment.
Adding a small test here would be nice
3 tasks
Replaced deployer address with production ownership: - ethereum: awSafes.ethereum - arbitrum: ICA 0xD2757Bbc (inline, commented out in aw.ts) - plasma: ICA 0x5f132a9a (from origin/main, not on audit branch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvmWarpModule.createHookUpdateTxs()no longer assertsproxyAdminfor unproxied OFT contractsDeployed Contracts
0xE4c1A1E54C232454311cF68610c3885FdD991c0E0x7Bb4fe8f406fB7B22487Fa2e3BCbCb6A38cF29E60x93bfFA2231fbA5029997603fb68D9aC08024Baa2SDK Fix (critical for OFT deployment)
enrollCrossChainRouterswas failing withProxyAdmin address is undefinedfor allcollateralOftdeployments.Root cause:
EvmWarpRouteReadersetshook: AddressZeroas a sentinel for unproxied OFT contracts.createHookUpdateTxscheckedif (!expectedConfig.hook)— butAddressZerois truthy, so it fell through to assertproxyAdminexists, which isundefinedfor unproxied contracts.Fix: Added
|| expectedConfig.hook === constants.AddressZeroto the early-return check increateHookUpdateTxs.Test Transfers (0.1 USDT each via LayerZero)
Related
TODO
ownersByChain) — currently using deployer addressTest plan
warp deploy— full deployment including router enrollment succeededcast send— 0.1 USDT sent in all 3 directions via LayerZero🤖 Generated with Claude Code