feat: unify warp route checks onto shared logic#8554
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughWarp route validation was refactored from a governor/checker workflow to a registry-driven validator ( Changes
Sequence Diagram(s)mermaid Possibly related issues
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Compared current HEAD This post-approval delta stayed checker-scoped, not a broad PR expansion.
Net behavior changes in the range:
The only meaningful ops-semantic change after approval is that config getter/load failures are now surfaced and fail the job at the end instead of being silently skipped. So I would characterize the post-approval delta as targeted warp-check follow-up fixes, not a drastic PR mutation. |
Summary
check-warp-deployon the shared checker while restoring getter-aware expected configs for routes backed bywarpConfigGetterMapproxyAdmin.addressmismatches andownerOverridesownership checkscheck-deploy/deploysurfacesHypERC20AppandHypERC20Checkerexports and implementationHYPERLANE_SKIP_VERSION_CHECK=1is setTesting
pnpm -C typescript/sdk checkNODE_OPTIONS='--import tsx/esm' pnpm -C typescript/sdk exec hardhat --config hardhat.config.cts test ./src/token/deploy.hardhat-test.ts --grep 'checkWarpRouteDeployConfig'pnpm -C typescript/infra checkNote
High Risk
High because it replaces legacy Warp checking/deploy surfaces and removes public SDK exports (
HypERC20App/HypERC20Checker), which can break downstream integrations and subtly change on-chain config comparison behavior.Overview
Warp route checking is replaced with a shared SDK-based comparator (
checkWarpRouteDeployConfig) that returns structured diffs/violations used by both the CLIwarp checkand the infracheck-warp-deploycron.The new check adds explicit
proxyAdmin.addressmismatch detection and owner override ownership checks (e.g., collateral token/proxy admin owners), improves mixed-VM route handling (avoid false remote-router diffs while still validating scale across route members), and tweaks config expansion to preserveproxyAdminfields and optionally skip scale validation.Infra tooling is simplified by removing
WARPfrom genericdeploy/check-deploymodule flows and refactoring warp config loading to be registry/getter-aware; the SDK makes a major breaking change by removingHypERC20App/HypERC20Checkerexports/implementation and exporting the new warp check API. CLI also skips version checks in CI or whenHYPERLANE_SKIP_VERSION_CHECK=1.Reviewed by Cursor Bugbot for commit 1f87bf2. Bugbot is set up for automated code reviews on this repo. Configure here.