chore: update @hyperlane-xyz/registry to 25.0.0#8570
chore: update @hyperlane-xyz/registry to 25.0.0#8570hyper-gonk[bot] wants to merge 1 commit intomainfrom
Conversation
hyper-gonk
Bot
requested review from
Mo-Hussain,
Xaroz,
nambrot,
paulbalaji,
tkporter,
troykessler,
xeno097,
yjamin and
yorhodes
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8570 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 143 143
Lines 4278 4278
Branches 436 436
=======================================
Hits 3394 3394
Misses 855 855
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚩 Lockfile inconsistency: catalog entry removed but workspace config retained
The lockfile diff shows the catalogs section had @hyperlane-xyz/registry removed (lines deleted from the lockfile's catalog block), while pnpm-workspace.yaml still defines it. This creates a lockfile that is out of sync with the workspace configuration. A subsequent pnpm install by another developer would either fail (due to catalogMode: strict) or regenerate the lockfile differently, causing merge conflicts.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🚩 No changeset added for published packages
REVIEW.md states "Required for published packages — Any change to typescript/ packages needs a changeset." Several modified packages are published (e.g., @hyperlane-xyz/helloworld, @hyperlane-xyz/relayer, @hyperlane-xyz/widgets, @hyperlane-xyz/tron-sdk). However, since the only change is bumping a dependency version without any API or behavioral changes to the packages themselves, a changeset may not be strictly necessary — this is a gray area. CI changeset checks will enforce this if required.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "@hyperlane-xyz/core": "workspace:*", | ||
| "@hyperlane-xyz/metrics": "workspace:*", | ||
| "@hyperlane-xyz/registry": "catalog:", | ||
| "@hyperlane-xyz/registry": "24.3.0", |
There was a problem hiding this comment.
🟡 Registry version hardcoded in package.json files instead of updating the pnpm catalog, leaving a stale orphaned catalog entry
The PR replaces "catalog:" with "25.0.0" in 13 package.json files but does not update the @hyperlane-xyz/registry entry in pnpm-workspace.yaml:83, which still reads 24.3.0. This leaves a stale orphaned catalog entry and breaks the established pattern where all shared dependencies use the catalog: protocol (as documented in the workspace's own comment at pnpm-workspace.yaml:12: "Require catalog: protocol for all cataloged dependencies"). The workspace uses catalogMode: strict.
This creates two concrete risks:
- Stale catalog entry: If any new package references
@hyperlane-xyz/registryusing"catalog:", it will silently resolve to24.3.0instead of the intended25.0.0. - Maintenance burden: Future registry version bumps now require updating 13 individual package.json files instead of a single catalog entry in
pnpm-workspace.yaml.
The correct fix is to update pnpm-workspace.yaml line 83 from 24.3.0 to 25.0.0 and keep using "catalog:" in all package.json files.
Was this helpful? React with 👍 or 👎 to provide feedback.
hyper-gonk
Bot
force-pushed
the
ci/update-registry-dep
branch
from
fb379c1 to
0dc867e
Compare
| "@hyperlane-xyz/core": "workspace:*", | ||
| "@hyperlane-xyz/metrics": "workspace:*", | ||
| "@hyperlane-xyz/registry": "catalog:", | ||
| "@hyperlane-xyz/registry": "24.3.0", |
There was a problem hiding this comment.
🚩 Hardcoding defeats the purpose of centralized version management
The entire catalog system (pnpm-workspace.yaml:15-17) exists to provide a single place to manage shared dependency versions. Replacing catalog: with hardcoded "24.3.0" in 13 files means future registry version bumps require editing 13 files instead of 1. This defeats the DRY principle that the catalog enforces. If there's a specific reason to decouple the registry version from the catalog (e.g., per-package version pinning), that rationale should be documented.
Was this helpful? React with 👍 or 👎 to provide feedback.
- Update @hyperlane-xyz/registry to 25.0.0 - Update pnpm-lock.yaml
hyper-gonk
Bot
force-pushed
the
ci/update-registry-dep
branch
from
0dc867e to
ce0f586
Compare
hyper-gonk
Bot
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Node Services Docker Image Built Successfully
Full image paths |
Automated Dependency Update
This PR updates the @hyperlane-xyz/registry dependency to the latest version.
Updated version:
@hyperlane-xyz/registry:25.0.0Changes include:
package.jsonfiles with latest registry versionpnpm-lock.yamlviapnpm install🤖 This PR was automatically generated by the update-registry-dep workflow