Draft
Conversation
Bumps snarkvm, snarkvm-algorithms, and snarkvm-console-account from 4.3.0 to 4.6.0. The Aleo team recommends 4.6.0 for both testnet and mainnet. Adapts two breaking changes in hyperlane-aleo: - Renames the removed `cost_in_microcredits_v3` to its 4.6 equivalent `minimum_cost_in_microcredits_v3` (identical signature). - `VM::authorize` now returns `VmAuthError` instead of `anyhow::Error`; convert through `anyhow::Error` so it continues to flow into the existing `HyperlaneAleoError::SnarkVmError` variant.
Adds an ignored tokio::test that hits https://api.explorer.provable.com/v2/mainnet and calls get_block for 17918388..=17918398, panicking on the first error. Currently fails on 17918388 with a snarkvm decode error ("Mismatching solution ID, possible data corruption"). Intended as a reproducer for the Aleo team while we investigate.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tkporter
force-pushed
the
trevor/snarkvm-4.6.0
branch
from
9a38429 to
882bd6d
Compare
Contributor
🦀 Rust Agent Docker Image Built Successfully
Full image paths |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snarkvm,snarkvm-algorithms, andsnarkvm-console-accountfrom4.3.0→4.6.0inrust/main/Cargo.toml(+ lockfile).hyperlane-aleo:cost_in_microcredits_v3→minimum_cost_in_microcredits_v3(identical signature).VM::authorizenow returnsVmAuthErrorinstead ofanyhow::Error; wrapped throughanyhow::Errorinto the existingHyperlaneAleoError::SnarkVmErrorvariant.Context
The Aleo team recommends
4.6.0for both testnet and mainnet. They are investigating a release channel for us so we know what to update.The added
tokio::test(provider::tests::provable_mainnet_get_block_range,#[ignore], hits livehttps://api.explorer.provable.com/v2/mainnet) still fails on block17918388with:Same error as on 4.3.0 — the version bump alone does not resolve it. Keeping the failing test committed as a reproducer for follow-up with the Aleo team. Please hold off on review until that's sorted.
Test plan
cargo build -p hyperlane-aleocargo clippy --features aleo,integration_test -- -D warnings(CI-matching)cargo test -p hyperlane-aleo— 70/70 existing tests passcargo test -p hyperlane-aleo -- --ignored provable_mainnet_get_block_range— currently fails on purpose (see above)