feat(cairo): change mailbox fee token at compile time#21
feat(cairo): change mailbox fee token at compile time#21aroralanuk wants to merge 1 commit intomainfrom
Conversation
yorhodes
left a comment
yorhodes
left a comment
There was a problem hiding this comment.
we should commit the address value config to version control on each branch and put it behind the existing build pipeline
| pub fn ETH_ADDRESS() -> ContractAddress { | ||
| 0x049D36570D4e46f48e99674bd3fcc84644DdD6b96F7C741B1562B82f9e004dC7.try_into().unwrap() | ||
| FEE_TOKEN() | ||
| } |
There was a problem hiding this comment.
should we change usage of ETH_ADDRESS to FEE_TOKEN to avoid this (improperly named) indirection?
There was a problem hiding this comment.
not totally clear that we need this
There was a problem hiding this comment.
agree doesn't necessarily need to be a Makefile, but I don't feel strongly
I think it'd be nice though to have an experience like make build starknet or make build paradex so you don't need to know the fee token addresses each time you run a command
| @@ -0,0 +1,38 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
can we name this file with a .sh suffix
There was a problem hiding this comment.
agree doesn't necessarily need to be a Makefile, but I don't feel strongly
I think it'd be nice though to have an experience like make build starknet or make build paradex so you don't need to know the fee token addresses each time you run a command
yorhodes
force-pushed
the
kunal/dyn-fee-token-const
branch
from
900509b to
00e88b1
Compare
|
closing in favor of #22 |
3 participants
No description provided.