feat: support intents #446

fernandomg · 2025-02-28T20:11:00Z

This PR may require a history cleanup, but I'm leaving it as testimonial of the multiple iterartions. We went from a proxy (CoreProxy) to only extend WarpCore with the required specific functionalities to support intents, by leveraging EvmAdapters the more we can (check hyperlane-xyz/hyperlane-monorepo#5588)

I'm not sure how HL team does to evaluate SDK/UI modification locally. In my case I used yalc (I tried using yarn link, but have multiple issues and couldn't find any guide on how to proceed). As I said, with yalc publish/update I managed to test the SDK changes along with this UI modifications.

vercel · 2025-02-28T20:11:05Z

@fernandomg is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

fernandomg · 2025-02-28T20:23:30Z

src/features/store.ts

+          txs[i].orderId ||= options?.orderId;
+          txs[i].remoteTxHash ||= options?.remoteTxHash;


two extra attributes added to the tx information. This will help to track the intent completion and to host the transfer information on the destination chain.

fernandomg · 2025-02-28T20:24:26Z

src/features/tokens/TokenListModal.tsx

+                {isIntentStandard(t.token.standard) && (
+                  <>
+                    <span>-</span>
+                    <span>
+                      <i>via intents</i>
+                    </span>
+                  </>
+                )}


if it's an intent, we let the user know (this is useful in the case that the same token can be bridged via WR or intents)

fernandomg · 2025-02-28T20:24:50Z

src/features/tokens/balances.ts

@@ -86,3 +88,44 @@ export function useEvmWalletBalance(

  return { balance: data, isError, isLoading };
 }
+export async function checkOrderFilled({


polls for the destination chain Filling

fernandomg · 2025-02-28T20:25:40Z

src/features/transfer/types.ts

@@ -13,6 +13,7 @@ export enum TransferStatus {
  ConfirmingApprove = 'confirming-approve',
  SigningTransfer = 'signing-transfer',
  ConfirmingTransfer = 'confirming-transfer',
+  WaitingForFulfillment = 'waiting-for-fulfillment',


a new transfer status

fernandomg · 2025-02-28T20:26:33Z

src/features/warpCore/warpCoreConfig.ts

@@ -57,7 +57,7 @@ function filterToIds(
 function dedupeTokens(tokens: WarpCoreConfig['tokens']): WarpCoreConfig['tokens'] {
  const idToToken: Record<string, WarpCoreConfig['tokens'][number]> = {};
  for (const token of tokens) {
-    const id = `${token.chainName}|${token.addressOrDenom?.toLowerCase()}`;
+    const id = `${token.chainName}|${token.addressOrDenom?.toLowerCase()}|${token.standard.toLowerCase()}`;


we need to also differentiate by standard, to permit a token to be birdged via WR and/or intents

fernandomg · 2025-03-05T18:37:10Z

src/consts/warpRoutes.ts

Warning
an example file for testing purposes, this change should be removed before merging.

Xaroz · 2025-03-26T19:39:23Z

src/consts/warpRoutes.ts

+const ROUTER = '0x6d2175B89315A9EB6c7eA71fDE54Ac0f294aDC34';
+const ITT = '0x5f94BC7Fb4A2779fef010F96b496cD36A909E818';


can we have this in the const/config.ts or const/args.ts file?

sure, if you want to keep these in the codebase.

My idea was to leave this file untocuched after the PR feedback (i.e.: roll back these changes).

My intention was to share some implementation reference to help on the feedback.

Xaroz · 2025-03-26T19:41:25Z

src/features/tokens/balances.ts

+        clearInterval(intervalId);
+        reject(error);
+      }
+    }, 4_000);


can we have this in a constant value?

I extracted both values as constants (10 and 4_000) but inside the checkOrderFilled as it's strictly tied to this solutions.

Would you like me to extract them as constants/env variables?

Xaroz · 2025-03-26T19:41:53Z

src/features/tokens/balances.ts

+    const intervalId = setInterval(async () => {
+      try {
+        const to = await provider.getBlockNumber();
+        const from = to - 10;


what does this 10 represent? Might be a good idea to also a const value for this

Xaroz · 2025-03-26T19:43:03Z

src/features/transfer/TransfersDetailsModal.tsx

+  return (
+    transfer.remoteTxHash && (
+      <TransferProperty
+        name={name}
+        value={transfer.remoteTxHash ?? ''}
+        url={
+          multiProvider.tryGetExplorerTxUrl(transfer.destination, {
+            hash: transfer.remoteTxHash,
+          }) ?? ''
+        }
+      />
+    )
+  );


nit, can you do something like:

if (!transfer.remoteTxHash) return null return <TransferProperty ..../>

Xaroz · 2025-03-26T19:43:36Z

src/features/transfer/useTokenTransfer.ts

+    const orderId = (txReceipt?.receipt as TransactionReceipt)?.logs?.find(
+      (log) =>
+        log.topics[0].toLowerCase() ===
+        '0x3448bbc2203c608599ad448eeb1007cea04b788ac631f9f558e8dd01a3c27b3d', // `Open` event


nit: have this address in a const value

same as the other constants. The more I create them, the more I feel that they need to be moved into an "intent-related" set of constants.

ljankovic-txfusion · 2025-03-27T12:12:50Z

src/features/tokens/balances.ts

@@ -1,5 +1,7 @@
+import { Hyperlane7683__factory as Hyperlane7683Factory } from '@bootnodedev/intents-framework-core';
+import { FilledEvent } from '@bootnodedev/intents-framework-core/dist/src/Base7683';


Is there a way to also import FilledEvent from '@bootnodedev/intents-framework-core'? without path ...dist/src/Base7683

removed that type import, as it's inferred

fernandomg commented Feb 28, 2025

View reviewed changes

fernandomg force-pushed the main branch from f36d6f9 to d0485c9 Compare March 5, 2025 18:33

fernandomg commented Mar 5, 2025

View reviewed changes

src/consts/warpRoutes.ts

Copy link

Member Author

fernandomg Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning
an example file for testing purposes, this change should be removed before merging.

fernandomg force-pushed the main branch from d0485c9 to e253d6b Compare March 25, 2025 09:17

Xaroz reviewed Mar 26, 2025

View reviewed changes

ljankovic-txfusion reviewed Mar 27, 2025

View reviewed changes

fernandomg added 8 commits March 31, 2025 11:44

feat: support intents

602cee8

feat: identify tokens also by standard

7decb6b

feat: display if a token will be bridged via intents

f0c6a18

feat: recognize intents in the UI

bb270a2

fix: remove unneeded type assertion

5dd8856

fix: extract values to const variables

fc7a3a0

refactor: guard clause for conditional rendering

52b7874

refactor: extract to constant Open intent topic hash

052c6ef

fernandomg force-pushed the main branch from e253d6b to 052c6ef Compare March 31, 2025 13:22

fernandomg requested review from Xaroz and ljankovic-txfusion March 31, 2025 13:23

		txs[i].orderId \|\|= options?.orderId;
		txs[i].remoteTxHash \|\|= options?.remoteTxHash;

		const ROUTER = '0x6d2175B89315A9EB6c7eA71fDE54Ac0f294aDC34';
		const ITT = '0x5f94BC7Fb4A2779fef010F96b496cD36A909E818';

		@@ -1,5 +1,7 @@
		import { Hyperlane7683__factory as Hyperlane7683Factory } from '@bootnodedev/intents-framework-core';
		import { FilledEvent } from '@bootnodedev/intents-framework-core/dist/src/Base7683';

feat: support intents #446

Are you sure you want to change the base?

feat: support intents #446

Uh oh!

Conversation

fernandomg commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Feb 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fernandomg commented Feb 28, 2025 •

edited

Loading