feat: remove deprecated field and remove BorshError string#6
Open
kamiyaa wants to merge 1 commit intohyperlane-1.14.13from
Open
feat: remove deprecated field and remove BorshError string#6kamiyaa wants to merge 1 commit intohyperlane-1.14.13from
kamiyaa wants to merge 1 commit intohyperlane-1.14.13from
Conversation
paulbalaji
reviewed
Dec 24, 2025
Author
There was a problem hiding this comment.
A test vector block from solana mainnet
kamiyaa
force-pushed
the
jeff/encoded-tx-2
branch
from
a4857c4 to
8828871
Compare
ameten
reviewed
Jan 7, 2026
Comment on lines
+1473
to
+1490
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_deserialize_encoded_transaction() { | ||
| const JSON_STR: &str = include_str!("./tests/transaction-1.json"); | ||
| let tx: EncodedTransactionWithStatusMeta = serde_json::from_str(JSON_STR).unwrap(); | ||
|
|
||
| eprintln!("tx {:?}", tx); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_deserialize_ui_confirmed_block() { | ||
| const JSON_STR: &str = include_str!("./tests/388662392.json"); | ||
| let res: UiConfirmedBlock = serde_json::from_str(JSON_STR).unwrap(); | ||
| eprintln!("res {:?}", res); | ||
| } |
Author
There was a problem hiding this comment.
Just testing if its able to deserialize what gets returned from RPC
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
new rpc getBlock responses are not able to be parsed
Bug report: Breaking change in BorshIoError enum leading to deserialization errors anza-xyz/solana-sdk#394
https://github.com/anza-xyz/solana-sdk/blob/723ed3864816b0054762c613c02fba0ba9615fdf/README.md?plain=1#L115
instruction-error: deserialize old format for BorshIoError anza-xyz/solana-sdk#404
https://github.com/anza-xyz/solana-sdk/blob/723ed3864816b0054762c613c02fba0ba9615fdf/instruction-error/src/lib.rs#L184
Summary of Changes
pub status: TransactionResult<()>field