Skip to content

Conversation

@pandaio22
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Closes #4016

@pandaio22
Copy link
Contributor Author

[WIP]
Next steps:

  1. Improve robustness of the audits by persisting audit data. Create a new type audit data "Audit" that the audit endpoint should return; Create a new SQL schema for and "AuditEntry". Persist in the local database audit information as sessions advance. An "AuditEntry" is an array of enhanced "SessionData". Enhanced session data is a session data object augmented with one or more bungee proofs. An "Audit" is a collection of "AuditEntry".

  2. Refactor audit endpoint to retrieve and return audit data from the database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(satp-hermes): improve audit endpoint

1 participant