Skip to content

Fix the bug that ApproveForm component in dashboard does not display the selection box of channel. #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeasy merged 4 commits into from
Apr 12, 2025
Merged

Fix the bug that ApproveForm component in dashboard does not display the selection box of channel. #666

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5c24b5
fix bug of approveform not showing channel
YoungHypo Jan 18, 2025
e99375d
update node to 20.15 in tests/dashboard
YoungHypo Feb 11, 2025
640992a
fix prettier in approveform
YoungHypo Feb 15, 2025
12046f2
set node back to 14.18 in test/docker-compose.yml
YoungHypo Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/dashboard/src/pages/ChainCode/forms/ApproveForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const FormItem = Form.Item;
const ApproveForm = props => {
const [form] = Form.useForm();
const intl = useIntl();
const [channels, setChannels] = useState();
const [channels, setChannels] = useState([]);
const {
approveModalVisible,
handleApprove,
Expand All @@ -20,11 +20,15 @@ const ApproveForm = props => {
} = props;

useEffect(() => {
async function fecthData() {
async function fetchData() {
const response = await listChannel();
setChannels(response.data.data);
const newChannels = Object.keys(response.data.data).map(item => ({
label: response.data.data[item].name,
value: response.data.data[item].name,
}));
setChannels(newChannels);
}
fecthData();
fetchData();
}, []);

const approveCallback = response => {
Expand Down Expand Up @@ -107,7 +111,7 @@ const ApproveForm = props => {
id: 'app.chainCode.form.approve.channel',
defaultMessage: 'Please select channel',
})}
name="channel"
name="channels"
rules={[
{
required: true,
Expand All @@ -120,9 +124,8 @@ const ApproveForm = props => {
>
<Select
mode="multiple"
options={channels} // dummyChannels changed
options={channels}
tagRender={tagRender}
defaultValue={[]}
dropdownClassName={styles.dropdownClassName}
/>
</FormItem>
Expand Down