Fix chaincode installation to use selected node ID #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chaincode installation form in the frontend allows users to select a specific peer node, but the backend was always using the first peer regardless of selection. This change modifies the install method in views.py to properly use the node ID provided in the request. - Added logic to check for node_id parameter in the request - Use the selected node if provided instead of defaulting to first peer - Added error handling for invalid node selections Fixes hyperledger-cello#677 Signed-off-by: Anshuman ojha <[email protected]>
YoungHypo
reviewed
May 20, 2025
Contributor
YoungHypo
left a comment
YoungHypo
left a comment
There was a problem hiding this comment.
in related frontend component, we also need to fliter the nodes, cause ordered node is not allowed to install chaincodes.
When installing chaincodes, only peer nodes should be available for selection since orderer nodes cannot install chaincodes. This change modifies the InstallForm component to: - Filter node list to only show peer nodes - Remove orderer nodes from selection options - Improve UX by preventing invalid node selections This ensures users can only select valid peer nodes for chaincode installation, preventing potential errors from attempting to install on orderer nodes. Fixes hyperledger-cello#677 Signed-off-by: Anshuman ojha <[email protected]>
Signed-off-by: Anshuman Ojha <[email protected]>
YoungHypo
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chaincode installation form in the frontend allows users to select a specific peer node, but the backend was always using the first peer regardless of selection. This change modifies the install method in views.py to properly use the node ID provided in the request.
Fixes #677
Signed-off-by: Anshuman ojha [email protected]