Skip to content

Conversation

@Survey845
Copy link
Contributor

@Survey845 Survey845 commented May 19, 2025

Made changes to the rest of the exception handling in the codebase in the attempt to improve observability and for ease of understanding why an error may have occurred.

  • Implemented .exception() instead of .error() in most places because exc_info is default True.
  • Replaced .warn() with .exception() because it has deprecated.
  • Added Messages for Exceptions defined in exceptions.py files to better explain what goes wrong (ResourceNotFound, ResourceExists, etc.)
  • Used the Logger (LOG) in all the files it was already being implemented in.

Survey845 added 2 commits May 19, 2025 16:17
Have replaced .error() with .exception() as exc_info is default True and added detail/custom message with the Exceptions if done so for others in the file previously

Signed-off-by: jaimukund bhan <[email protected]>
@yeasy yeasy merged commit d67c442 into hyperledger-cello:main May 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants