Skip to content

Conversation

@dodo920306
Copy link
Contributor

  1. Remove the suffix ": password" for the login form.
    Before:

    After:

  2. Since validation.email.required and validation.email.wrong-format mention email as "邮箱地址", change placeholder text in the login form also as "邮箱地址".

  3. Add space between "selected" and the number.
    Before:

    After:

Remove the suffix ": password" in login form password placeholder so that
it will not be shown as `password: password` or `密码: password` in Chinese.

Signed-off-by: dodo920306 <[email protected]>
Add space between message "selected" and the number.

Signed-off-by: dodo920306 <[email protected]>
@yeasy yeasy requested review from YoungHypo and xichen1 June 10, 2025 02:26
@dodo920306
Copy link
Contributor Author

dodo920306 commented Jun 14, 2025

Well, it seems like the dashboard has enzyme as a devDependency, which in turn depends on cheerio. Five days ago, cheerio released a new version 1.1.0, which upgrades its dependency on undici from ^6.19.5 to ^7.10.0. Starting from [email protected], the minimum required Node.js version has been bumped to >=20.18.1.

Shall we consider updating the Node.js version in the base image of the dashboard? Or we can add

  "resolutions": {
    "cheerio": "1.0.0"
  }

Or include yarn.lock in the project (I prefer this the most).

Do you want me to make this a seperate issue?

YoungHypo
YoungHypo previously approved these changes Jun 20, 2025
@YoungHypo
Copy link
Contributor

YoungHypo commented Jun 20, 2025

Well, it seems like the dashboard has enzyme as a devDependency, which in turn depends on cheerio. Five days ago, cheerio released a new version 1.1.0, which upgrades its dependency on undici from ^6.19.5 to ^7.10.0. Starting from [email protected], the minimum required Node.js version has been bumped to >=20.18.1.

Shall we consider updating the Node.js version in the base image of the dashboard? Or we can add

  "resolutions": {
    "cheerio": "1.0.0"
  }

Or include yarn.lock in the project (I prefer this the most).

Do you want me to make this a seperate issue?

I didn’t find any usage of Enzyme in the dashboard, so maybe we can just remove it? @dodo920306

@dodo920306
Copy link
Contributor Author

I didn’t find any usage of Enzyme in the dashboard, so maybe we can just remove it? @dodo920306

Well, I'm actually not sure. It's not my project in the first place anyway. I don't know how it get in here in our package.json.

I can build the dashboard locally with Enzyme removed from my package.json. That's the best I can do to test if it can be safely removed.

Besides, it just treats the symptom not the cause. Including some sort of lock files (e.g. yarn.lock) and introducing automatical dependency management tools (e.g. dependabot) are the true solutions.

@yeasy yeasy merged commit fb85c0f into hyperledger-cello:main Jun 29, 2025
3 checks passed
@dodo920306 dodo920306 deleted the fix/redundant-placeholder branch June 29, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants