-
Notifications
You must be signed in to change notification settings - Fork 445
Fix some UI wording and typeset #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some UI wording and typeset #689
Conversation
Remove the suffix ": password" in login form password placeholder so that it will not be shown as `password: password` or `密码: password` in Chinese. Signed-off-by: dodo920306 <[email protected]>
Signed-off-by: dodo920306 <[email protected]>
Add space between message "selected" and the number. Signed-off-by: dodo920306 <[email protected]>
|
Well, it seems like the dashboard has enzyme as a devDependency, which in turn depends on cheerio. Five days ago, cheerio released a new version 1.1.0, which upgrades its dependency on undici from Shall we consider updating the Node.js version in the base image of the dashboard? Or we can add "resolutions": {
"cheerio": "1.0.0"
}Or include Do you want me to make this a seperate issue? |
I didn’t find any usage of Enzyme in the dashboard, so maybe we can just remove it? @dodo920306 |
Well, I'm actually not sure. It's not my project in the first place anyway. I don't know how it get in here in our I can build the dashboard locally with Enzyme removed from my Besides, it just treats the symptom not the cause. Including some sort of lock files (e.g. |
Remove the suffix ": password" for the login form.


Before:
After:


Since
validation.email.requiredandvalidation.email.wrong-formatmention email as "邮箱地址", change placeholder text in the login form also as "邮箱地址".Add space between "selected" and the number.


Before:
After:

