Fix wrong username/password be shown as session expired #699
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to rest_framework/views.py of django-rest-framework, AuthenticationFailed is actaully be handled as 401 not 400. This commit moves login failure handler from 400 to 401, so that the dashboard can show the right message. As for 400 errors, they will be handled as general exceptions. Signed-off-by: dodo920306 <[email protected]>
YoungHypo
approved these changes
Jun 20, 2025
…ith-session-expire
…ith-session-expire
…ith-session-expire
…ith-session-expire
dodo920306
deleted the
fix/wrong-username-or-password-is-confused-with-session-expire
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rest_framework/views.py of django-rest-framework, AuthenticationFailed is actaully be handled as 401 not 400.
This commit moves login failure handler from 400 to 401, so that the dashboard can show the right message.
As for 400 errors, they will be handled as general exceptions.