Re-activate flake8 checks for CI jobs #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there is a mismatch between practical python version and tox usage. While Cello now uses Python 3.8 actually, **`tox.ini` still expect python 3.5 to be used**. This actually causes **all flake8 checks have been skipped** since the python version was bumped. Leaving all the code unchecked. This commit aims to reactivate the flake8 checks for CI jobs by bump the version of python expected by tox. Signed-off-by: dodo920306 <[email protected]>
Signed-off-by: dodo920306 <[email protected]>
Signed-off-by: dodo920306 <[email protected]>
Contributor
Author
|
Please notice that this PR simpifies the Such changes require tests to check if the functionality isn't broken. |
Signed-off-by: dodo920306 <[email protected]>
yeasy
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there is a mismatch between practical python version and tox usage. While Cello now uses Python 3.8 actually,
tox.inistill expect python 3.5 to be used. This actually causes all flake8 checks have been skipped since the python version was bumped. Leaving all the code unchecked.This commit aims to reactivate the flake8 checks for CI jobs by bump the version of python expected by tox.