chore: remove file-level eslint-disable directives in PresentationVerify.ts (#650)#656
Open
A-Chronicle wants to merge 1 commit into
Conversation
…ify.ts Remove 4 file-level eslint-disable directives and fix each type violation with proper type annotations and runtime validation: - Replace any with unknown in method signatures for type safety - Use Record<string, unknown> casts at data boundary points - Add runtime type narrowing (typeof checks, instanceof checks) - Use inline as type assertions where values originate from external APIs (credential.id, credential.issuer, etc.) - Fix catch block error handling: use err instanceof Error instead of (err as Error).message pattern - Fix SDJWT issuer type: convert string to DID via DID.fromString() - Fix template literal type errors with explicit string casts Signed-off-by: A-Chronicle <chaubeyanshika319@gmail.com>
A-Chronicle
force-pushed
the
fix/remove-eslint-disable-PresentationVerify
branch
from
d139e60 to
ae264d6
Compare
|
Contributor
Author
|
hey @elribonazo ! I fixed this issue yesterday and it would be just great if you can review it and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #650
Removes 4 file-level eslint-disable directives and fixes each type violation with proper type annotations and runtime validation:
any→unknownin method signatures for type safetyRecord<string, unknown>casts at data boundary pointstypeofchecks,instanceofchecks)astype assertions where values originate from external APIs (credential.id, credential.issuer, etc.)err instanceof Errorinstead of(err as Error).messagepatternDID.fromString()(was passing string where DID was expected)Lint passes with 0 errors.