fix select version protoc for install #655
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedor Partanskiy <[email protected]>
tock-ibm
reviewed
Dec 2, 2025
| env: | ||
| GO_VER: 1.25.3 | ||
| PROTOC_VER: 33.0 | ||
| PROTOC_VER: "33.0" |
Contributor
There was a problem hiding this comment.
@pfi79 why is it a problem? is in interpreted as a number instead of a version?
Contributor
Author
There was a problem hiding this comment.
the robot tried to throw a pr that failed validation. The installation of protocol 33.0 is specified, but action installed 33.1. For some reason they missed a significant 0. The quotation marks made it so that action would not skip this zero.
here is an example of a version change error
Contributor
Author
There was a problem hiding this comment.
I'm trying to fix this situation, and then I'll restart the robot pipes.
tock-ibm
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.