-
Notifications
You must be signed in to change notification settings - Fork 93
feat: support installing chaincode from Docker image using CCAAS #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support installing chaincode from Docker image using CCAAS #550
Conversation
|
@dpereowei that looks good, have you tested it locally? It would be good to make it as a part of one of pipelines. I think
This test in CI would allow us to ensure it actually works, and how it behaves when tls is enabled (currently there is hardcoded Also an additional comment - I see you create the chaincode archive in |
|
Hi @dzikowski, I appreciate your feedback and I will get to working on the tests, thanks |
b6d5793 to
f459423
Compare
src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh
Outdated
Show resolved
Hide resolved
src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh
Outdated
Show resolved
Hide resolved
src/validate/index.ts
Outdated
| const networkConfig = parseFabloConfig(this.fs.read(this.options.fabloConfigPath)); | ||
| this._validateFabricVersion(networkConfig.global); | ||
| this._validateJsonSchema(networkConfig); | ||
| // this._validateJsonSchema(networkConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the line that fails tests in CI
|
@dpereowei please squash these commits |
… is lower than 2.5 Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
…the versions for fabric shim Signed-off-by: Sanket <telisanket2002@gmail.com> added the snapshots Signed-off-by: Sanket <telisanket2002@gmail.com> suggest recommended node Signed-off-by: Sanket <telisanket2002@gmail.com> reafactored the code to avoid the breaking due to import of v1.4 added the snapshots fixed the function, now it is returning the proper required version Signed-off-by: Sanket Teli <telisanket2002@gmail.com> Update src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh Co-authored-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com> Signed-off-by: Sanket Teli <104385297+Sanket-0510@users.noreply.github.com> changes the directory location Signed-off-by: Sanket Teli <telisanket2002@gmail.com> added snapshots Signed-off-by: Sanket Teli <telisanket2002@gmail.com>
Signed-off-by: Sanket Teli <telisanket2002@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Sanket Teli <telisanket2002@gmail.com>
Signed-off-by: Sanket Teli <telisanket2002@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-update test suites for code changes Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-update test suites for code changes Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-update test suites for code changes Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> Fix-review comments and file changes Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> Fix-updated test suites for new code changes Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-validate json schema Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-re-enable explorer test and update changelog Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-add .DS_STORE to gitignore Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> fix-increase validation warning count Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> generate certs using openssl for cc container Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> feat-generate-tls-certs-for-ccaass-container Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com> feat-prepare-main-for-ccaas-tls-issue Signed-off-by: Pereowei Daniel <iwenyadaniel12@gmail.com>
2c9a4d0 to
fe6bdcb
Compare
Signed-off-by: Pereowei Daniel <82245725+dpereowei@users.noreply.github.com>
|
handled in #594 |
#429 link 429
This PR supports installing and running chaincode from a Docker image (CCaaS mode), rather than a local directory. It’s useful for teams who prefer building and deploying chaincode separately.
lang: "ccaas"is now supported in chaincode definitionslangisccaas:imageandportare requireddirectoryis optionalExample config
{ "name": "chaincode1", "version": "0.0.1", "lang": "ccaas", "channel": "my-channel1", "image": "realartisan/chaincode-kv-node:latest", "port": 7052 }