Skip to content

test: fix flaky snapshot ccaas test with retry loop #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzikowski merged 6 commits into from
Jan 23, 2026
+3 −0
Merged

test: fix flaky snapshot ccaas test with retry loop #648

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5ff959
test: fix flaky snapshot ccaas test with retry loop
OsamaRab3 Jan 18, 2026
687405e
update sleep time
OsamaRab3 Jan 18, 2026
06baa2e
add initial wait before retrying
OsamaRab3 Jan 18, 2026
cd3d7df
remove retry loop
OsamaRab3 Jan 18, 2026
8e386b3
reduce sleep time to 2
OsamaRab3 Jan 19, 2026
ed19fcb
Merge branch 'main' into fix-647
OsamaRab3 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions e2e-network/docker/test-04-v3-snapshot-ccaas.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,15 @@ echo "$user_token_response"
user_token="$(echo "$user_token_response" | jq -r '.token')"

# check if state is kept after restoration
expectInvokeRest "$fablo_rest_org1 $user_token" "my-channel1" "chaincode1" \
"KVContract:get" '["name"]' \
'{"response":{"success":"Mr Freeze"}}'
sleep 10
Copy link
Contributor

@dzikowski dzikowski Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a predictable behavior with shorter sleep? like 2 seconds for instance?

for i in {1..10}; do
Copy link
Contributor Author

@OsamaRab3 OsamaRab3 Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is now passing consistently, so a retry loop is no longer required

echo "Checking restored data, attempt #$i"
expectInvokeRest "$fablo_rest_org1 $user_token" "my-channel1" "chaincode1" \
"KVContract:get" '["name"]' \
'{"response":{"success":"Mr Freeze"}}' && break
sleep 5
done

expectInvokeRest "$fablo_rest_org1 $user_token" "my-channel1" "chaincode1" \
"KVContract:getPrivateMessage" '["_implicit_org_Org1MSP"]' \
'{"success":"RHIgVmljdG9yIEZyaWVz"}'
Expand Down
Loading