Fix deadlock in chaincode event #1051
Merged
+256
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
added
cleanup
mbrandenburger
force-pushed
the
cc-event
branch
2 times, most recently
from
14d06b2 to
0fd34b3
Compare
mbrandenburger
force-pushed
the
cc-event
branch
from
0fd34b3 to
484fd14
Compare
mbrandenburger
force-pushed
the
cc-event
branch
from
484fd14 to
84025b6
Compare
mbrandenburger
force-pushed
the
cc-event
branch
from
84025b6 to
1ace4b9
Compare
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
cc-event
branch
from
bf294d4 to
877eb8e
Compare
- Revise fabric.EventListener - Add additional tests Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
cc-event
branch
from
877eb8e to
a9e57bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When revising the cc event integration test and use a single network instance to run all existing tests, it turned out that the the chaincode
EventListenerimplementation has a liveness issue.This PR restructures the cc event integration test and use a single network instance to run all existing tests.
We add a unit test that captures the liveness issue with the chaincode event listener and propose a fix to overcome the issue.
Note that this PR currently is based on #1049