Skip to content

feature: Initial impl for committer's notification service #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbrandenburger merged 2 commits into from
Nov 25, 2025
Merged

feature: Initial impl for committer's notification service #1075

mbrandenburger merged 2 commits into from
Nov 25, 2025

Conversation

@SaidAltury-ibm
Copy link
Contributor

@SaidAltury-ibm SaidAltury-ibm commented Nov 10, 2025 •
edited
Loading

This PR introduces:

  • the committer's notification service.
  • the fabricx/simple end-to-end integration test.
  • new unit test for the Network Listener Manager (NLM) component (found in platform/fabricx/core/generic/nlm).

TODO next:

  • implement how to load the configurations
  • improve the implementation of Listener Manager to allow listening to notification through a single instance

@SaidAltury-ibm SaidAltury-ibm added this to the 25Q4 milestone Nov 10, 2025
@SaidAltury-ibm SaidAltury-ibm self-assigned this Nov 10, 2025
@SaidAltury-ibm SaidAltury-ibm marked this pull request as draft November 10, 2025 09:13
mbrandenburger
mbrandenburger requested changes Nov 20, 2025
View reviewed changes
Copy link
Member

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SaidAltury-ibm this is great step forward on this PR. Please consider my comments.

@mbrandenburger
Copy link
Member

mbrandenburger commented Nov 20, 2025

@SaidAltury-ibm I think with your new unit tests we can remove notify/notify_test.go.

@SaidAltury-ibm SaidAltury-ibm changed the title add Simple integration test to FSC PR Description: Simple Integration Test and NLM Unit Test Nov 23, 2025
@SaidAltury-ibm SaidAltury-ibm changed the title PR Description: Simple Integration Test and NLM Unit Test Simple Integration Test and NLM Unit Test Nov 23, 2025
@SaidAltury-ibm SaidAltury-ibm added the testing All related to testing label Nov 23, 2025
mbrandenburger
mbrandenburger reviewed Nov 25, 2025
View reviewed changes
Copy link
Member

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress @SaidAltury-ibm

@mbrandenburger @SaidAltury-ibm
feature: Initial impl for committer's notification service
153324c 
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
@SaidAltury-ibm SaidAltury-ibm changed the title Simple Integration Test and NLM Unit Test feature: Initial impl for committer's notification service Nov 25, 2025
@SaidAltury-ibm
test: Add tests for notification service
e9a546c 
- add Simple integration test
- add unit test
- implement removeFinalityListener

Signed-off-by: Said Altury <Said.Altury@ibm.com>
@mbrandenburger mbrandenburger mentioned this pull request Nov 25, 2025
Closed
@SaidAltury-ibm SaidAltury-ibm marked this pull request as ready for review November 25, 2025 15:30
@mbrandenburger mbrandenburger merged commit 192abfd into hyperledger-labs:main Nov 25, 2025
23 checks passed
@AkramBitar AkramBitar mentioned this pull request Jan 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrandenburger mbrandenburger mbrandenburger approved these changes

Assignees

@mbrandenburger mbrandenburger

@SaidAltury-ibm SaidAltury-ibm

Labels

testing All related to testing

Projects

None yet

Milestone

25Q4

Development

Successfully merging this pull request may close these issues.

2 participants

@SaidAltury-ibm @mbrandenburger