refactor(fabric/services/endorser): better support for unit-testing #1077 #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
approved these changes
Nov 17, 2025
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @adecaro LGTM. One minor change request below.
Contributor
Author
|
@mbrandenburger , apologies, I didn't set the status. The PR is still in progress. I'll push more stuff. When ready, I'll ask you to review again. Thanks. |
Member
I set this PR to draft. |
adecaro
force-pushed
the
1077-add-constructors-to-the-fabric-api-to-support-unit-testing
branch
from
6dbba11 to
57b7ad5
Compare
Contributor
Author
|
@mbrandenburger @SaidAltury-ibm , I still have a function to add. Sorry for that. |
adecaro
force-pushed
the
1077-add-constructors-to-the-fabric-api-to-support-unit-testing
branch
from
446f400 to
48f3786
Compare
mbrandenburger
changed the title
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Co-authored-by: Marcus Brandenburger <mbrandenburger@users.noreply.github.com> Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com> Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
1077-add-constructors-to-the-fabric-api-to-support-unit-testing
branch
from
48f3786 to
bdb3f53
Compare
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
mbrandenburger
deleted the
1077-add-constructors-to-the-fabric-api-to-support-unit-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add constructors to allow the developer to construct mocks more easily.
This PR is connected to hyperledger-labs/fabric-token-sdk#1265.