refactor: enhanced uuid #1095
Merged
refactor: enhanced uuid #1095
+113
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/utils/uuid.go
Outdated
Comment on lines
53
to
63
| if poolPos == randPoolSize { | ||
| _, err := io.ReadFull(rand.Reader, pool[:]) | ||
| if err != nil { | ||
| poolMu.Unlock() | ||
| panic(fmt.Sprintf("Error generating UUID: %s", err)) | ||
| } | ||
| poolPos = 0 | ||
| } | ||
| copy(uuid[:], pool[poolPos:(poolPos+16)]) | ||
| poolPos += 16 | ||
| poolMu.Unlock() |
Contributor
There was a problem hiding this comment.
does't that break RFC 4122 assumption (a Universally Unique IDentifier is unique across both space and time, with respect to the space of all UUIDs) and introduce correlation between consecutive UUIDs (each 16)? and the locking limits parallel UUID generation in high scale do we want that?
WYT?
Member
Author
There was a problem hiding this comment.
interesting thoughts! I've remove this impl an added github.com/google/uuid. I think there is no need to reinvent the wheel here.
Member
Author
There was a problem hiding this comment.
I did some benchmarking, and even though with the lock used here, it is still faster than doing a sys call for each operations.
- switch to github.com/google/uuid for uuids - more allocation friendly uuid string function - uuid benchmarks - remove GenerateUUIDOnlyLetters Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
SaidAltury-ibm
approved these changes
Dec 2, 2025
Contributor
SaidAltury-ibm
left a comment
SaidAltury-ibm
left a comment
There was a problem hiding this comment.
Looks Good, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.